Message-ID: <1475873387.1945.23.camel@perches.com>
Subject: Re: [PATCH 1/3] Staging: i4l: Warning "Prefer "pr_debug over
 printk(KERN_DEBUG... " fixed
From: Joe Perches <joe@perches.com>
To: Harman Kalra <harman4linux@gmail.com>, gregkh@linuxfoundation.org,
        sudipm.mukherjee@gmail.co
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Fri, 07 Oct 2016 13:49:47 -0700
In-Reply-To: <1475859476-3524-1-git-send-email-harman4linux@gmail.com>
References: <20161005065219.GD11013@kroah.com>
         <1475859476-3524-1-git-send-email-harman4linux@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 646
Lines: 16

On Fri, 2016-10-07 at 22:27 +0530, Harman Kalra wrote:
> Warning "Prefer "pr_debug over printk(KERN_DEBUG... " and "few line more than 80 character" fixed

The commit subject and message doesn't match the code change.

> diff --git a/drivers/staging/i4l/icn/icn.h b/drivers/staging/i4l/icn/icn.h
[]
> @@ -54,7 +54,8 @@
>  
>  /* some useful macros for debugging */
>  #ifdef ICN_DEBUG_PORT
> -#define OUTB_P(v, p) {printk(KERN_DEBUG "icn: outb_p(0x%02x,0x%03x)\n", v, p); outb_p(v, p);}
> +#define OUTB_P(v, p) \
> +		{printk(KERN_DEBUG "icn: outb_p(0x%02x,0x%03x)\n", v, p); outb_p(v, p); }

This would be better with a do {...} while (0) guard