Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757550AbcJHD5Y (ORCPT ); Fri, 7 Oct 2016 23:57:24 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:60004 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752145AbcJHD5X (ORCPT ); Fri, 7 Oct 2016 23:57:23 -0400 Date: Fri, 07 Oct 2016 23:57:18 -0400 (EDT) Message-Id: <20161007.235718.1329800164848117692.davem@davemloft.net> To: xander.huff@ni.com Cc: nicolas.ferre@atmel.com, netdev@vger.kernel.org, nathan.sullivan@ni.com, linux-kernel@vger.kernel.org, brad.mouring@ni.com Subject: Re: [PATCH] net: macb: NULL out phydev after removing mdio bus From: David Miller In-Reply-To: <1475853202-19903-1-git-send-email-xander.huff@ni.com> References: <1475853202-19903-1-git-send-email-xander.huff@ni.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 07 Oct 2016 20:57:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 558 Lines: 15 From: Xander Huff Date: Fri, 7 Oct 2016 10:13:22 -0500 > From: Nathan Sullivan > > To ensure the dev->phydev pointer is not used after becoming invalid in > mdiobus_unregister, set it to NULL. This happens when removing the macb > driver without first taking its interface down, since unregister_netdev > will end up calling macb_close. > > Signed-off-by: Xander Huff > Signed-off-by: Nathan Sullivan > Signed-off-by: Brad Mouring Applied.