Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751783AbcJHEO1 (ORCPT <rfc822;w@1wt.eu>);
        Sat, 8 Oct 2016 00:14:27 -0400
Received: from cn.fujitsu.com ([59.151.112.132]:18082 "EHLO
        heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
        with ESMTP id S1751015AbcJHEOS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 8 Oct 2016 00:14:18 -0400
X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; 
   d="scan'208";a="11726170"
Subject: Re: [tip:x86/apic] x86/acpi: Introduce persistent storage for cpuid
 <-> apicid mapping
To: Thomas Gleixner <tglx@linutronix.de>
References: <1472114120-3281-4-git-send-email-douly.fnst@cn.fujitsu.com>
 <tip-8f54969dc8d6704632b42cbb5e47730cd75cc713@git.kernel.org>
 <CAE9FiQVQx6FRXT-RdR7Crz4dg5LeUWHcUSy1KacjR+JgU_vGJg@mail.gmail.com>
 <alpine.DEB.2.20.1610041258410.7712@nanos>
 <CAE9FiQWigWvrZ8JzNDKtZ9FWARh2m0kGoF+VOZdwAdY9vnU3_w@mail.gmail.com>
 <4608f474-c49e-550b-90e2-c5f4c25e00f5@cn.fujitsu.com>
 <alpine.DEB.2.20.1610071506140.19804@nanos>
CC: Yinghai Lu <yinghai@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        "linux-tip-commits@vger.kernel.org" 
        <linux-tip-commits@vger.kernel.org>,
        Tony Luck <tony.luck@intel.com>
From: Dou Liyang <douly.fnst@cn.fujitsu.com>
Message-ID: <866f5115-f472-d630-d73b-26eba88debad@cn.fujitsu.com>
Date: Sat, 8 Oct 2016 12:14:11 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1610071506140.19804@nanos>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.167.226.106]
X-yoursite-MailScanner-ID: D2C6C42BC52E.AC34D
X-yoursite-MailScanner: Found to be clean
X-yoursite-MailScanner-From: douly.fnst@cn.fujitsu.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 417
Lines: 26

Hi tglx,

At 10/07/2016 09:07 PM, Thomas Gleixner wrote:
> On Thu, 6 Oct 2016, Dou Liyang wrote:
>>
>> +       if (processor->id >= 255) {
>> +               ++disabled_cpus;
>
> Incrementing disabled_cpus here is simply wrong because 0xff is an invalid
> local APIC id. So we can simply return -EINVAL and be done with it.
>

Yes, It is.

>> +               return -EINVAL;
>
> Thanks,
>
> 	tglx
>
>

Thanks,

	Dou