Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758007AbcJHK61 (ORCPT ); Sat, 8 Oct 2016 06:58:27 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:33281 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756068AbcJHK6S (ORCPT ); Sat, 8 Oct 2016 06:58:18 -0400 MIME-Version: 1.0 In-Reply-To: <1474367987-15808-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1474367987-15808-1-git-send-email-arvind.yadav.cs@gmail.com> From: Joachim Eastwood Date: Sat, 8 Oct 2016 12:58:16 +0200 Message-ID: Subject: Re: [PATCH] clk: nxp: clk-lpc18xx-ccu: Unmap region obtained by of_iomap To: Arvind Yadav Cc: Michael Turquette , Stephen Boyd , linux-clk , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1365 Lines: 46 Hi Arvind, On 20 September 2016 at 12:39, Arvind Yadav wrote: > From: Arvind Yadav > > Free memory mapping, if lpc18xx_ccu_init is not successful. > > Signed-off-by: Arvind Yadav Acked-by: Joachim Eastwood One comment below: > --- > drivers/clk/nxp/clk-lpc18xx-ccu.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/nxp/clk-lpc18xx-ccu.c b/drivers/clk/nxp/clk-lpc18xx-ccu.c > index f7136b9..27781b4 100644 > --- a/drivers/clk/nxp/clk-lpc18xx-ccu.c > +++ b/drivers/clk/nxp/clk-lpc18xx-ccu.c > @@ -277,12 +277,15 @@ static void __init lpc18xx_ccu_init(struct device_node *np) > } > > clk_data = kzalloc(sizeof(*clk_data), GFP_KERNEL); > - if (!clk_data) > + if (!clk_data) { > + iounmap(reg_base); > return; > + } You could also move the kzalloc() at the beginning of the function to save a few lines. I am fine either way. > > clk_data->num = of_property_count_strings(np, "clock-names"); > clk_data->name = kcalloc(clk_data->num, sizeof(char *), GFP_KERNEL); > if (!clk_data->name) { > + iounmap(reg_base); > kfree(clk_data); > return; > } regards, Joachim Eastwood