Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935255AbcJHOQH (ORCPT ); Sat, 8 Oct 2016 10:16:07 -0400 Received: from spo001.leaseweb.nl ([85.17.2.162]:40219 "EHLO spo001.leaseweb.nl" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1756709AbcJHOPO (ORCPT ); Sat, 8 Oct 2016 10:15:14 -0400 Date: Sat, 8 Oct 2016 16:03:48 +0200 From: Wim Van Sebroeck To: Matt Redfearn Cc: linux-kernel@vger.kernel.org, Guenter Roeck , linux-watchdog@vger.kernel.org Subject: Re: [PATCH] watchdog: rt2880_wdt: Remove assignment of dev pointer Message-ID: <20161008140348.GC23290@spo001.leaseweb.nl> References: <1473672913-10484-1-git-send-email-matt.redfearn@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1473672913-10484-1-git-send-email-matt.redfearn@imgtec.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 833 Lines: 26 Hi Matt, > Commit 0254e953537c ("watchdog: Drop pointer to watchdog device from > struct watchdog_device") removed the dev pointer from struct > watchdog_device, but this driver was still assigning it, leading to a > compilation error: > > drivers/watchdog/rt2880_wdt.c: In function ‘rt288x_wdt_probe’: > drivers/watchdog/rt2880_wdt.c:161:16: error: ‘struct watchdog_device’ > has no member named ‘dev’ > rt288x_wdt_dev.dev = &pdev->dev; > ^ > scripts/Makefile.build:289: recipe for target > 'drivers/watchdog/rt2880_wdt.o' failed > > Fix this by removing the assignment. > > Fixes: 0254e953537c > Signed-off-by: Matt Redfearn > --- This patch and a similar patch from Guenter regarding mt7621_wdt was added to linux-watchdog-next almost 2 weeks ago. Kind regards, Wim.