Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756915AbcJHQB0 (ORCPT ); Sat, 8 Oct 2016 12:01:26 -0400 Received: from mga05.intel.com ([192.55.52.43]:25207 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756161AbcJHQBQ (ORCPT ); Sat, 8 Oct 2016 12:01:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,461,1473145200"; d="scan'208";a="1062214447" Date: Sat, 8 Oct 2016 19:01:12 +0300 From: Jarkko Sakkinen To: "Winkler, Tomas" Cc: "tpmdd-devel@lists.sourceforge.net" , Jason Gunthorpe , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb Message-ID: <20161008160112.GB25893@intel.com> References: <1475927979-23484-1-git-send-email-tomas.winkler@intel.com> <1475927979-23484-5-git-send-email-tomas.winkler@intel.com> <20161008124708.GA10317@intel.com> <5B8DA87D05A7694D9FA63FD143655C1B542F6741@hasmsx108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B542F6741@hasmsx108.ger.corp.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 962 Lines: 23 On Sat, Oct 08, 2016 at 01:37:31PM +0000, Winkler, Tomas wrote: > > > > On Sat, Oct 08, 2016 at 02:59:39PM +0300, Tomas Winkler wrote: > > > From: "Winkler, Tomas" > > > > > > Utilize runtime_pm for driving tpm crb idle states. > > > The framework calls cmd_ready from the pm_runtime_resume handler and > > > go idle from the pm_runtime_suspend handler. > > > The TPM framework should wake the device before transmit and receive. > > > In case the runtime_pm framework is not compiled in or enabled, the > > > device will be in the permanent ready state. > > > > > > Signed-off-by: Tomas Winkler > > > > I would rather want the fix as a separate patch to make review + testing easier > > (without and with). Thanks. > > But you've dropped the patches, so I've resent them. > Can you do the diff yourself, just branch it off. it's really just few lines Nope. I have only dropped the workaround. /Jarkko