Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757244AbcJHQmQ (ORCPT ); Sat, 8 Oct 2016 12:42:16 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:44768 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753136AbcJHQmI (ORCPT ); Sat, 8 Oct 2016 12:42:08 -0400 Date: Sat, 8 Oct 2016 10:42:03 -0600 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: "Winkler, Tomas" , "tpmdd-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state Message-ID: <20161008164203.GB29734@obsidianresearch.com> References: <1475927979-23484-1-git-send-email-tomas.winkler@intel.com> <1475927979-23484-3-git-send-email-tomas.winkler@intel.com> <20161008125003.GB10317@intel.com> <5B8DA87D05A7694D9FA63FD143655C1B542F6768@hasmsx108.ger.corp.intel.com> <20161008160006.GA25893@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161008160006.GA25893@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 476 Lines: 14 On Sat, Oct 08, 2016 at 07:00:06PM +0300, Jarkko Sakkinen wrote: > Rather you it would be better not to use cmdReady/goIdle at all if > kernel is not compiled with CONFIG_PM. It would be best practice to ensure the tpm is powered up no matter how the kernel is compiled.. The firmware may have left it in idle or something FWIW, I broadly agree there is no need to put the device into idle on the error paths. It probably wasn't idle when the driver attached to it. Jason