Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757198AbcJHQ6j convert rfc822-to-8bit (ORCPT ); Sat, 8 Oct 2016 12:58:39 -0400 Received: from mga03.intel.com ([134.134.136.65]:55175 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752845AbcJHQ6d (ORCPT ); Sat, 8 Oct 2016 12:58:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,461,1473145200"; d="scan'208";a="17584852" From: "Winkler, Tomas" To: Jason Gunthorpe , Jarkko Sakkinen CC: "tpmdd-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state Thread-Topic: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state Thread-Index: AQHSIVu/ZnkPL5o4ZkCC1sbu6MZMlKCeT/eAgAA/wRD///VYAIAAC7mAgAA2hpA= Date: Sat, 8 Oct 2016 16:58:28 +0000 Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B542F67DF@hasmsx108.ger.corp.intel.com> References: <1475927979-23484-1-git-send-email-tomas.winkler@intel.com> <1475927979-23484-3-git-send-email-tomas.winkler@intel.com> <20161008125003.GB10317@intel.com> <5B8DA87D05A7694D9FA63FD143655C1B542F6768@hasmsx108.ger.corp.intel.com> <20161008160006.GA25893@intel.com> <20161008164203.GB29734@obsidianresearch.com> In-Reply-To: <20161008164203.GB29734@obsidianresearch.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTY0ZjE4YjYtZDg4Mi00ODk1LWIzMzAtMjhlMWJlMzBlZWM0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjZNdmt5aWpVZEN0bXlVVERHUjFtQjVSOGhUb2VBaDhGRlJwVlpkNHAxSlU9In0= x-originating-ip: [10.184.70.11] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 676 Lines: 15 > On Sat, Oct 08, 2016 at 07:00:06PM +0300, Jarkko Sakkinen wrote: > > > Rather you it would be better not to use cmdReady/goIdle at all if > > kernel is not compiled with CONFIG_PM. > > It would be best practice to ensure the tpm is powered up no matter how the > kernel is compiled.. The firmware may have left it in idle or something > > FWIW, I broadly agree there is no need to put the device into idle on the error > paths. It probably wasn't idle when the driver attached to it. Actually, currently it is more common to have the device in the idle state, so in case a driver is not loaded for any reason by the kernel, the platform won't leak power. Thanks Tomas