Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935070AbcJHRI5 (ORCPT ); Sat, 8 Oct 2016 13:08:57 -0400 Received: from mga06.intel.com ([134.134.136.31]:2879 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932206AbcJHRIm (ORCPT ); Sat, 8 Oct 2016 13:08:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,461,1473145200"; d="scan'208";a="1051183108" Date: Sat, 8 Oct 2016 20:08:37 +0300 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: "Winkler, Tomas" , "tpmdd-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state Message-ID: <20161008170837.GB8747@intel.com> References: <1475927979-23484-1-git-send-email-tomas.winkler@intel.com> <1475927979-23484-3-git-send-email-tomas.winkler@intel.com> <20161008125003.GB10317@intel.com> <5B8DA87D05A7694D9FA63FD143655C1B542F6768@hasmsx108.ger.corp.intel.com> <20161008160006.GA25893@intel.com> <20161008164203.GB29734@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161008164203.GB29734@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 704 Lines: 21 On Sat, Oct 08, 2016 at 10:42:03AM -0600, Jason Gunthorpe wrote: > On Sat, Oct 08, 2016 at 07:00:06PM +0300, Jarkko Sakkinen wrote: > > > Rather you it would be better not to use cmdReady/goIdle at all if > > kernel is not compiled with CONFIG_PM. > > It would be best practice to ensure the tpm is powered up no matter > how the kernel is compiled.. The firmware may have left it in idle or > something > > FWIW, I broadly agree there is no need to put the device into idle on > the error paths. It probably wasn't idle when the driver attached to > it. I'll keep the current commit because it's anyway tested code. If I want to change this I'll send a separate patch for review. > Jason /Jarkko