MIME-Version: 1.0
In-Reply-To: <1475894763-64683-2-git-send-email-fenghua.yu@intel.com>
References: <1475894763-64683-1-git-send-email-fenghua.yu@intel.com> <1475894763-64683-2-git-send-email-fenghua.yu@intel.com>
From: Nilay Vaish <nilayvaish@gmail.com>
Date: Sat, 8 Oct 2016 12:11:08 -0500
Message-ID: <CACbG309=ERARyRQCxWG6GrgRG91TPcSOO-ieTzBEe7d94uM=hg@mail.gmail.com>
Subject: Re: [PATCH v3 01/18] Documentation, ABI: Add a document entry for
 cache id
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        "H. Peter Anvin" <h.peter.anvin@intel.com>,
        Ingo Molnar <mingo@elte.hu>, Tony Luck <tony.luck@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Stephane Eranian <eranian@google.com>, Borislav Petkov <bp@suse.de>,
        Dave Hansen <dave.hansen@intel.com>, Shaohua Li <shli@fb.com>,
        David Carrillo-Cisneros <davidcc@google.com>,
        Ravi V Shankar <ravi.v.shankar@intel.com>,
        Sai Prakhya <sai.praneeth.prakhya@intel.com>,
        Vikas Shivappa <vikas.shivappa@linux.intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1845
Lines: 42

On 7 October 2016 at 21:45, Fenghua Yu <fenghua.yu@intel.com> wrote:
> From: Fenghua Yu <fenghua.yu@intel.com>
>
> Add an ABI document entry for /sys/devices/system/cpu/cpu*/cache/index*/id.
>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>  Documentation/ABI/testing/sysfs-devices-system-cpu | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu b/Documentation/ABI/testing/sysfs-devices-system-cpu
> index 4987417..b1c3d69 100644
> --- a/Documentation/ABI/testing/sysfs-devices-system-cpu
> +++ b/Documentation/ABI/testing/sysfs-devices-system-cpu
> @@ -272,6 +272,22 @@ Description:       Parameters for the CPU cache attributes
>                                      the modified cache line is written to main
>                                      memory only when it is replaced
>
> +
> +What:          /sys/devices/system/cpu/cpu*/cache/index*/id
> +Date:          September 2016
> +Contact:       Linux kernel mailing list <linux-kernel@vger.kernel.org>
> +Description:   Cache id
> +
> +               The id provides a unique name for a specific instance of
> +               a cache of a particular type. E.g. there may be a level
> +               3 unified cache on each socket in a server and we may
> +               assign them ids 0, 1, 2, ...
> +
> +               Note that id value may not be contiguous. E.g. level 1
> +               caches typically exist per core, but there may not be a
> +               power of two cores on a socket, so these caches may be
> +               numbered 0, 1, 2, 3, 4, 5, 8, 9, 10, ...
> +

While it is ok that the caches are not numbered contiguously, it is
unclear how this is related to number of cores on a socket being a
power of 2 or not.

--
Nilay