Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753336AbcJHVDC (ORCPT ); Sat, 8 Oct 2016 17:03:02 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34600 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752795AbcJHVCx (ORCPT ); Sat, 8 Oct 2016 17:02:53 -0400 Subject: Re: [PATCH v3] pwm: add depends, COMPILE_TEST and default y for brcm-iproc-pwm To: Scott Branden , Thierry Reding References: <1475960045-19313-1-git-send-email-scott.branden@broadcom.com> Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, BCM Kernel Feedback From: Ray Jui Message-ID: <8b29ebaa-eaaa-2f77-6408-a476af3aaa84@broadcom.com> Date: Sat, 8 Oct 2016 14:02:51 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:49.0) Gecko/20100101 Thunderbird/49.0 MIME-Version: 1.0 In-Reply-To: <1475960045-19313-1-git-send-email-scott.branden@broadcom.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 978 Lines: 33 On 10/8/2016 1:54 PM, Scott Branden wrote: > - Add depends on COMMON_CLK for PWM_BCM_IPROC > - Enable COMPILE_TEST for broader compile coverage. > - Default y for IPROC PWM driver for IPROC SoCs. > This allows you to turn it on simply by selecting CONFIG_PWM. > > Signed-off-by: Scott Branden > --- > drivers/pwm/Kconfig | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > index 80a566a..3eb1b6b 100644 > --- a/drivers/pwm/Kconfig > +++ b/drivers/pwm/Kconfig > @@ -76,7 +76,9 @@ config PWM_ATMEL_TCB > > config PWM_BCM_IPROC > tristate "iProc PWM support" > - depends on ARCH_BCM_IPROC > + depends on ARCH_BCM_IPROC || COMPILE_TEST > + depends on COMMON_CLK > + default ARCH_BCM_IPROC > help > Generic PWM framework driver for Broadcom iProc PWM block. This > block is used in Broadcom iProc SoC's. > Looks good to me! Reviewed-by: Ray Jui