Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932162AbcJIJqQ (ORCPT ); Sun, 9 Oct 2016 05:46:16 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34220 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932140AbcJIJqP (ORCPT ); Sun, 9 Oct 2016 05:46:15 -0400 References: <20160920025532.GC30020@yexl-desktop> <20160930092658.0da22cad@canb.auug.org.au> User-agent: mu4e 0.9.17; emacs 25.1.1 From: Mathieu OTHACEHE To: Stephen Rothwell Cc: Al Viro , LKML , lkp@01.org, Michal Marek Subject: Re: [lkp] [x86] 784d5699ed: kmsg.ip_tables:no_symbol_version_for_copy_from_user In-reply-to: <20160930092658.0da22cad@canb.auug.org.au> Date: Sun, 09 Oct 2016 11:46:12 +0200 Message-ID: <8737k5c0t7.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 750 Lines: 24 Hi, > Do we have any resolution of this? I got the exact same problem if CONFIG_MODVERSIONS is enabled. Here is my understanding. All the symbols exported using assembler macro EXPORT_SYMBOL will need a __crc_ to be defined later on (include/asm-generic/export.h). This is what genksyms should do but it only runs on *.c files. So all the symbols exported from *.S files won't get crc. modpost is complaining about missing crc and it will not include those symbols in *.mod.c modversion_info struct. Then, we got "Unknown symbol" errors when modules are inserted at runtime. I fixed it locally by setting __crc_ to a constant value in export.h. But it may be a better idea to have genksyms run on *.S files ? Thanks, Mathieu