Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751972AbcJIO7q (ORCPT ); Sun, 9 Oct 2016 10:59:46 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59143 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751862AbcJIO7p (ORCPT ); Sun, 9 Oct 2016 10:59:45 -0400 Date: Sun, 9 Oct 2016 16:59:52 +0200 From: Greg KH To: Harman Kalra Cc: sudipm.mukherjee@gmail.co, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] Staging: i4l: Error "open brace { should be on the previous line" fixed. Message-ID: <20161009145952.GB26420@kroah.com> References: <20161005065219.GD11013@kroah.com> <1475859476-3524-1-git-send-email-harman4linux@gmail.com> <1475859476-3524-3-git-send-email-harman4linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475859476-3524-3-git-send-email-harman4linux@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 333 Lines: 10 On Fri, Oct 07, 2016 at 10:27:56PM +0530, Harman Kalra wrote: > Error "open brace { should be on the previous line" caught by checkpatch.pl fixed. > Signed-off-by: Harman Kalra Please put a blank line before the signed-off-by: line. As examples, look at all other commits in the tree :) thanks, greg k-h