Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752096AbcJIPVj (ORCPT ); Sun, 9 Oct 2016 11:21:39 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59422 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751783AbcJIPV2 (ORCPT ); Sun, 9 Oct 2016 11:21:28 -0400 Date: Sun, 9 Oct 2016 17:21:35 +0200 From: Greg KH To: Harman Kalra Cc: sudipm.mukherjee@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, bankarsandhya512@gmail.com Subject: Re: [PATCH] Staging: i4l: act2000: Fixed warning "use pr_* instead of printk" Message-ID: <20161009152135.GB5801@kroah.com> References: <20161009145134.GA9324@tuxzone> <1476025151-9645-1-git-send-email-harman4linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476025151-9645-1-git-send-email-harman4linux@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 733 Lines: 20 On Sun, Oct 09, 2016 at 08:29:11PM +0530, Harman Kalra wrote: > This patch replaces calls to the "printk" with appropriate "pr_*" > function thus addressing the following warning generated by the > checkpatch script: > > Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then > dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...:w > > Signed-off-by: Harman Kalra > --- > drivers/staging/i4l/act2000/act2000_isa.c | 25 +++++++++++-------------- > 1 file changed, 11 insertions(+), 14 deletions(-) This is a new version of the patch, so you need to version it, see the file, Documentation/SubmittingPatches for all of the details on how to do that properly. thanks, greg k-h