MIME-Version: 1.0
In-Reply-To: <1475894763-64683-11-git-send-email-fenghua.yu@intel.com>
References: <1475894763-64683-1-git-send-email-fenghua.yu@intel.com> <1475894763-64683-11-git-send-email-fenghua.yu@intel.com>
From: Nilay Vaish <nilayvaish@gmail.com>
Date: Sun, 9 Oct 2016 16:57:43 -0500
Message-ID: <CACbG30_XhaA3mzVEwy1L4u7OJNs0gzN4uAzL5PnC_t4Ym6MfTQ@mail.gmail.com>
Subject: Re: [PATCH v3 10/18] x86/intel_rdt: Build structures for each
 resource based on cache topology
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        "H. Peter Anvin" <h.peter.anvin@intel.com>,
        Ingo Molnar <mingo@elte.hu>, Tony Luck <tony.luck@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Stephane Eranian <eranian@google.com>, Borislav Petkov <bp@suse.de>,
        Dave Hansen <dave.hansen@intel.com>, Shaohua Li <shli@fb.com>,
        David Carrillo-Cisneros <davidcc@google.com>,
        Ravi V Shankar <ravi.v.shankar@intel.com>,
        Sai Prakhya <sai.praneeth.prakhya@intel.com>,
        Vikas Shivappa <vikas.shivappa@linux.intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1542
Lines: 50

On 7 October 2016 at 21:45, Fenghua Yu <fenghua.yu@intel.com> wrote:
> From: Tony Luck <tony.luck@intel.com>
>
> diff --git a/arch/x86/include/asm/intel_rdt.h b/arch/x86/include/asm/intel_rdt.h
> index 251ac2a..bad8dc7 100644
> --- a/arch/x86/include/asm/intel_rdt.h
> +++ b/arch/x86/include/asm/intel_rdt.h
> @@ -40,6 +40,39 @@ struct rdt_resource {
>                 if (r->enabled)
>
>  #define IA32_L3_CBM_BASE       0xc90
> +
> +/**
> + * struct rdt_domain - group of cpus sharing an RDT resource
> + * @list:      all instances of this resource
> + * @id:                unique id for this instance
> + * @cpu_mask:  which cpus share this resource
> + * @cbm:       array of cache bit masks (indexed by CLOSID)
> + */
> +struct rdt_domain {
> +       struct list_head        list;
> +       int                     id;
> +       struct cpumask          cpu_mask;
> +       u32                     *cbm;
> +};
> +
> +/**
> + * struct msr_param - set a range of MSRs from a domain
> + * @res:       The resource to use
> + * @low:       Beginning index from base MSR
> + * @high:      End index
> + */
> +struct msr_param {
> +       struct rdt_resource     *res;
> +       int                     low;
> +       int                     high;
> +};
> +
> +extern struct static_key_false rdt_enable_key;
> +extern struct mutex rdtgroup_mutex;
> +
> +int __init rdtgroup_init(void);
> +
> +extern struct rdtgroup *rdtgroup_default;

struct rdtgroup has not been defined yet.  The statement above should
be part of the next patch.

--
Nilay