Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751214AbcJIXq3 (ORCPT ); Sun, 9 Oct 2016 19:46:29 -0400 Received: from mail-qk0-f194.google.com ([209.85.220.194]:35181 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751041AbcJIXq1 (ORCPT ); Sun, 9 Oct 2016 19:46:27 -0400 MIME-Version: 1.0 In-Reply-To: <1476054436-9378-1-git-send-email-mayhs11saini@gmail.com> References: <1476054436-9378-1-git-send-email-mayhs11saini@gmail.com> From: Patrik Jakobsson Date: Mon, 10 Oct 2016 01:46:26 +0200 Message-ID: Subject: Re: [PATCH 1/1] gpu: drm: gma500: Use vma_pages() To: Shyam Saini Cc: David Airlie , dri-devel , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1205 Lines: 34 On Mon, Oct 10, 2016 at 1:07 AM, Shyam Saini wrote: > Replace explicit computation of vma page count by a call to > vma_pages() Hi, I already have this patch in the "queue" from: Muhammad Falak R Wani Will include that one when I get around to sending out a PR. Thanks Patrik > > Signed-off-by: Shyam Saini > --- > drivers/gpu/drm/gma500/framebuffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c > index 3a44e70..0fde850 100644 > --- a/drivers/gpu/drm/gma500/framebuffer.c > +++ b/drivers/gpu/drm/gma500/framebuffer.c > @@ -124,7 +124,7 @@ static int psbfb_vm_fault(struct vm_area_struct *vma, struct vm_fault *vmf) > unsigned long phys_addr = (unsigned long)dev_priv->stolen_base + > psbfb->gtt->offset; > > - page_num = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > + page_num = vma_pages(vma); > address = (unsigned long)vmf->virtual_address - (vmf->pgoff << PAGE_SHIFT); > > vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); > -- > 2.7.4 >