Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751598AbcJJBwz (ORCPT <rfc822;w@1wt.eu>);
        Sun, 9 Oct 2016 21:52:55 -0400
Received: from mail-io0-f196.google.com ([209.85.223.196]:35916 "EHLO
        mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751110AbcJJBwy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 9 Oct 2016 21:52:54 -0400
Message-ID: <1476064367.14200.0.camel@gmail.com>
Subject: Re: [PATCH 1/1] gpu: drm: gma500: Use vma_pages()
From: Shyam Saini <mayhs11saini@gmail.com>
To: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Date: Mon, 10 Oct 2016 07:22:47 +0530
In-Reply-To: <CAMeQTsbANnW5wg=5RO4mNPsR1kvqD-h_H-GkatG53nMqVFzoig@mail.gmail.com>
References: <1476054436-9378-1-git-send-email-mayhs11saini@gmail.com>
         <CAMeQTsbANnW5wg=5RO4mNPsR1kvqD-h_H-GkatG53nMqVFzoig@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.5.2-0ubuntu3 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1457
Lines: 45

On Mon, 2016-10-10 at 01:46 +0200, Patrik Jakobsson wrote:
> On Mon, Oct 10, 2016 at 1:07 AM, Shyam Saini <mayhs11saini@gmail.com>
> wrote:
> > 
> > Replace explicit computation of vma page count by a call to
> > vma_pages()
> Hi, I already have this patch in the "queue" from:
> Muhammad Falak R Wani <falakreyaz@gmail.com>
> 
> Will include that one when I get around to sending out a PR.
> 
> Thanks
> Patrik
> 
> > 
> > 
> > Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>
> > ---
> >  drivers/gpu/drm/gma500/framebuffer.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/gma500/framebuffer.c
> > b/drivers/gpu/drm/gma500/framebuffer.c
> > index 3a44e70..0fde850 100644
> > --- a/drivers/gpu/drm/gma500/framebuffer.c
> > +++ b/drivers/gpu/drm/gma500/framebuffer.c
> > @@ -124,7 +124,7 @@ static int psbfb_vm_fault(struct vm_area_struct
> > *vma, struct vm_fault *vmf)
> >         unsigned long phys_addr = (unsigned long)dev_priv-
> > >stolen_base +
> >                                   psbfb->gtt->offset;
> > 
> > -       page_num = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> > +       page_num = vma_pages(vma);
> >         address = (unsigned long)vmf->virtual_address - (vmf->pgoff 
> > << PAGE_SHIFT);
> > 
> >         vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
> > --
> > 2.7.4
> > 

No issue.

Thanks