Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752078AbcJJCu7 (ORCPT ); Sun, 9 Oct 2016 22:50:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51892 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751488AbcJJCu6 (ORCPT ); Sun, 9 Oct 2016 22:50:58 -0400 Date: Mon, 10 Oct 2016 10:50:50 +0800 From: Dave Young To: Greg Kroah-Hartman Cc: Arnd Bergmann , Kees Cook , linux-kernel@vger.kernel.org Subject: Re: Change CONFIG_DEVKMEM default value to n Message-ID: <20161010025050.GA3776@dhcp-128-65.nay.redhat.com> References: <20161007020411.GB9052@dhcp-128-65.nay.redhat.com> <20161007035719.GB17183@kroah.com> <20161010024436.GA3169@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161010024436.GA3169@dhcp-128-65.nay.redhat.com> User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 10 Oct 2016 02:50:57 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1506 Lines: 48 On 10/10/16 at 10:44am, Dave Young wrote: > On 10/07/16 at 05:57am, Greg Kroah-Hartman wrote: > > On Fri, Oct 07, 2016 at 10:04:11AM +0800, Dave Young wrote: > > > Kconfig comment suggests setting it as "n" if in doubt thus move the > > > default value to 'n'. > > > > > > Signed-off-by: Dave Young > > > Suggested-by: Kees Cook > > > --- > > > drivers/char/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > --- linux-x86.orig/drivers/char/Kconfig > > > +++ linux-x86/drivers/char/Kconfig > > > @@ -17,7 +17,7 @@ config DEVMEM > > > > > > config DEVKMEM > > > bool "/dev/kmem virtual device support" > > > - default y > > > + default n > > > > If you remove the "default" line, it defaults to 'n'. > > I personally perfer a "default n", but I can update it.. Greg, here is an update with dropping the default line: Move CONFIG_DEVKMEM default to n Kconfig comment suggests setting it as "n" if in doubt thus move the default value to 'n'. Signed-off-by: Dave Young Suggested-by: Kees Cook --- drivers/char/Kconfig | 1 - 1 file changed, 1 deletion(-) --- linux-x86.orig/drivers/char/Kconfig +++ linux-x86/drivers/char/Kconfig @@ -17,7 +17,6 @@ config DEVMEM config DEVKMEM bool "/dev/kmem virtual device support" - default y help Say Y here if you want to support the /dev/kmem device. The /dev/kmem device is rarely used, but can be used for certain