Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752009AbcJJD0z (ORCPT ); Sun, 9 Oct 2016 23:26:55 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:37754 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751521AbcJJD0y (ORCPT ); Sun, 9 Oct 2016 23:26:54 -0400 Date: Sun, 9 Oct 2016 21:26:50 -0600 From: Jason Gunthorpe To: "Winkler, Tomas" Cc: Jarkko Sakkinen , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [tpmdd-devel] [PATCH RFC 1/3] tpm_crb: expand struct crb_control_area to struct crb_regs Message-ID: <20161010032650.GA26695@obsidianresearch.com> References: <1475972112-2819-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1475972112-2819-2-git-send-email-jarkko.sakkinen@linux.intel.com> <20161009014256.GA8210@obsidianresearch.com> <20161009093818.GG31891@intel.com> <20161009164905.GA12551@obsidianresearch.com> <20161009183232.GA27764@intel.com> <20161009183358.GB27764@intel.com> <20161009230737.GA23823@obsidianresearch.com> <5B8DA87D05A7694D9FA63FD143655C1B542F7497@hasmsx108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B542F7497@hasmsx108.ger.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 355 Lines: 11 On Mon, Oct 10, 2016 at 12:25:11AM +0000, Winkler, Tomas wrote: > I addition I believe it should be always on offset FED4_0xxxh by the > Spec, so all this arithmetic is a bit of overkill. We don't have any hard coded addresses in the drivers - that seems very inappropriate these days.. Is that address really not discoverable via ACPI somehow? Jason