Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751734AbcJJFft (ORCPT <rfc822;w@1wt.eu>);
        Mon, 10 Oct 2016 01:35:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41212 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751597AbcJJFfr (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 10 Oct 2016 01:35:47 -0400
Date: Mon, 10 Oct 2016 13:35:41 +0800
From: Dave Young <dyoung@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Kees Cook <keescook@chromium.org>,
        linux-kernel@vger.kernel.org
Subject: Re: Change CONFIG_DEVKMEM default value to n
Message-ID: <20161010053541.GB5627@dhcp-128-65.nay.redhat.com>
References: <20161007020411.GB9052@dhcp-128-65.nay.redhat.com>
 <20161007035719.GB17183@kroah.com>
 <20161010024436.GA3169@dhcp-128-65.nay.redhat.com>
 <20161010025050.GA3776@dhcp-128-65.nay.redhat.com>
 <20161010051239.GA22781@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161010051239.GA22781@kroah.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 10 Oct 2016 05:35:47 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1232
Lines: 39

On 10/10/16 at 07:12am, Greg Kroah-Hartman wrote:
> On Mon, Oct 10, 2016 at 10:50:50AM +0800, Dave Young wrote:
> > On 10/10/16 at 10:44am, Dave Young wrote:
> > > On 10/07/16 at 05:57am, Greg Kroah-Hartman wrote:
> > > > On Fri, Oct 07, 2016 at 10:04:11AM +0800, Dave Young wrote:
> > > > > Kconfig comment suggests setting it as "n" if in doubt thus move the
> > > > > default value to 'n'.
> > > > > 
> > > > > Signed-off-by: Dave Young <dyoung@redhat.com>
> > > > > Suggested-by: Kees Cook <keescook@chromium.org>
> > > > > ---
> > > > >  drivers/char/Kconfig |    2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > 
> > > > > --- linux-x86.orig/drivers/char/Kconfig
> > > > > +++ linux-x86/drivers/char/Kconfig
> > > > > @@ -17,7 +17,7 @@ config DEVMEM
> > > > >  
> > > > >  config DEVKMEM
> > > > >  	bool "/dev/kmem virtual device support"
> > > > > -	default y
> > > > > +	default n
> > > > 
> > > > If you remove the "default" line, it defaults to 'n'.
> > > 
> > > I personally perfer a "default n", but I can update it..
> > 
> > Greg, here is an update with dropping the default line:
> 
> <snip>
> 
> Can you resend it in a format I can apply it in?

Done, thanks you!

> 
> thanks,
> 
> greg k-h