Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751593AbcJJJVQ (ORCPT ); Mon, 10 Oct 2016 05:21:16 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:50858 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015AbcJJJVO (ORCPT ); Mon, 10 Oct 2016 05:21:14 -0400 From: Arnd Bergmann To: Florian Fainelli Cc: Scott Branden , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, BCM Kernel Feedback Subject: Re: [PATCH] arm64: defconfig: enable EEPROM_AT25 config option Date: Mon, 10 Oct 2016 11:20:41 +0200 Message-ID: <1503155.onL8VV3RJv@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1475875432-13627-1-git-send-email-scott.branden@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:E5//sjbAti3yTZMIt/LlPcPZ5+8erZXSixzWP0gl8xQi5sEDGdS pNvrQSC9oOz7UnPZ65DjNMvzeC1Clv+4DNBU0Ci9W/PUnbnlp/NpRPmBcJT8rL3QvWvlt0/ KRArsrn5JO+vatC6MqVIwd/MdUM0JY+79HXXPLSF6wQkOcnabOS5oq0J0iOf/73OSufJL99 JdrM16kn7bStgqLUU+2lg== X-UI-Out-Filterresults: notjunk:1;V01:K0:MV6AON71ygE=:YSNc7YAkb6afrgI4Bqt+d/ G1MA+5/ItUGKhlCMVUAlo+aCc5NnyTugYthc6K4tPQWo0s05AVKgu0LZsk62KQGowavIWXFuL OIhFNScJpRss7FNAkijxDOQM0sm6sdOXFedgXPtaL/+TQNtWRNOdEuQUEFBGJdTaSgQojA2T5 xc5d6yhFzgdYsmEm9IFNgre7xJq6e2qs3hjZYlPs36yh9D0tonbWLoi/v/2flEFQMFkrDX/1+ hSMH2Ukh7avT/sJMKpfnST9mPlTTnFNpgpz/NLNtftFfBp/axtIXxmv7vS012zeod1eUGmqCY I95RWZQ+ZAfkW3/YsZqeEgEsS5XHUgNB5sLkkTINIDWDzb/DvCjqsz8yss7ghU9QVg/rUKFcy frfrMYJbjcTSIm2C+e7PIqY11Bx8buqnCYXqFOmOkI0quwjOs0vFbEQILdgfmgEsTD/Q91byK jAoa83C0XAyo28D4CdsI+XD4HqXdVd0N7b9xKt8bqSsr+2VCTs4bjEvdERCT6GiQWKDYZugk3 Q102RaBB8gdPot/bz+U24T1cUS8ely9TPgqJD5/s1MYYXErVS1Qt0/SqjI5ShhdpTykb0lfAU ARLNmrWWGuu6B7ouBwPX4qioj36fGikbxdskYT+S8F285jLFEtvX/YDclcaAufJ8crJ3H4aZx KPUaZSmXnizSsnNakykOZgjSqOm1wjQhYpqqrOICa9biWBPil9+aGAs7snv2RWA5d1FE3wNFd /NEsOrhQX+QD2CQ2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 447 Lines: 13 On Monday, October 10, 2016 2:08:05 AM CEST Florian Fainelli wrote: > On 10/07/2016 02:23 PM, Scott Branden wrote: > > Enable support for on board SPI EEPROM by turning on > > CONFIG_EEPROM_AT25. > > > > Signed-off-by: Scott Branden > > Looks fine to me, unless this needs to be a module, Arnd, what do you think? Please either make it a module or explain in the patch description why it should be built-in. Arnd