Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751710AbcJJJXy (ORCPT ); Mon, 10 Oct 2016 05:23:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:53934 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbcJJJXx (ORCPT ); Mon, 10 Oct 2016 05:23:53 -0400 Subject: Re: [PATCH] xenbus: advertize control feature flags To: Paul Durrant , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <1476085386-4544-1-git-send-email-paul.durrant@citrix.com> Cc: Boris Ostrovsky , David Vrabel From: Juergen Gross X-Enigmail-Draft-Status: N1110 Message-ID: Date: Mon, 10 Oct 2016 11:11:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1476085386-4544-1-git-send-email-paul.durrant@citrix.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1285 Lines: 39 On 10/10/16 09:43, Paul Durrant wrote: > The Xen docs specify several flags which a guest can set to advertize > which values of the xenstore control/shutdown key it will recognize. > This patch adds code to write all the relevant feature-flag keys. > > Signed-off-by: Paul Durrant > Cc: Boris Ostrovsky > Cc: David Vrabel > Cc: Juergen Gross > --- > drivers/xen/manage.c | 45 +++++++++++++++++++++++++++++++++++---------- > 1 file changed, 35 insertions(+), 10 deletions(-) > > diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c > index e12bd36..86cf57c 100644 > --- a/drivers/xen/manage.c > +++ b/drivers/xen/manage.c > @@ -170,6 +170,7 @@ out: > struct shutdown_handler { > const char *command; > void (*cb)(void); > + bool flag; > }; > > static int poweroff_nb(struct notifier_block *cb, unsigned long code, void *unused) > @@ -206,21 +207,22 @@ static void do_reboot(void) > ctrl_alt_del(); > } > > +static struct shutdown_handler shutdown_handlers[] = { > + { "poweroff", do_poweroff, true }, > + { "halt", do_poweroff, true }, > + { "reboot", do_reboot, false }, I think you meant to set the flag to "false" for halt and "true" for reboot, no? Juergen