Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751725AbcJJKPZ (ORCPT ); Mon, 10 Oct 2016 06:15:25 -0400 Received: from mail-qk0-f172.google.com ([209.85.220.172]:34325 "EHLO mail-qk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751368AbcJJKPY (ORCPT ); Mon, 10 Oct 2016 06:15:24 -0400 MIME-Version: 1.0 In-Reply-To: <20161010100107.GZ16071@codeblueprint.co.uk> References: <20160923115808.2330-1-matt@codeblueprint.co.uk> <20160928101422.GR5016@twins.programming.kicks-ass.net> <20160928193731.GD16071@codeblueprint.co.uk> <20161010100107.GZ16071@codeblueprint.co.uk> From: Wanpeng Li Date: Mon, 10 Oct 2016 18:09:14 +0800 Message-ID: Subject: Re: [PATCH] sched/fair: Do not decay new task load on first enqueue To: Matt Fleming Cc: Peter Zijlstra , Ingo Molnar , "linux-kernel@vger.kernel.org" , Mike Galbraith , Yuyang Du , Vincent Guittot , Dietmar Eggemann Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1191 Lines: 29 2016-10-10 18:01 GMT+08:00 Matt Fleming : > On Sun, 09 Oct, at 11:39:27AM, Wanpeng Li wrote: >> >> The difference between this patch and Peterz's is your patch have a >> delta since activate_task()->enqueue_task() does do update_rq_clock(), >> so why don't have the delta will cause low cpu machines (4 or 8) to >> regress against your another reply in this thread? > > Both my patch and Peter's patch cause issues with low cpu machines. In > <20161004201105.GP16071@codeblueprint.co.uk> I said, > > "This patch causes some low cpu machines (4 or 8) to regress. It turns > out they regress with my patch too." > > Have I misunderstood your question? I compare this one https://marc.info/?l=linux-kernel&m=147446511924571 with Peterz's patch. > > I ran out of time to investigate this last week, though I did try all > proposed patches, including Vincent's, and none of them produced wins > across the board. > > I should get a bit further this week. > > Vincent, Dietmar, did you guys ever get around to submitting your PELT > tracepoint patches? Getting some introspection into the scheduler's > load balancing decisions would speed up this sort of research.