Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752287AbcJJKQV (ORCPT ); Mon, 10 Oct 2016 06:16:21 -0400 Received: from smtp.citrix.com ([66.165.176.89]:3136 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751970AbcJJKQU (ORCPT ); Mon, 10 Oct 2016 06:16:20 -0400 X-IronPort-AV: E=Sophos;i="5.31,324,1473120000"; d="scan'208";a="383228379" Subject: Re: [PATCH v2] xenbus: advertize control feature flags To: Paul Durrant , , References: <1476092625-14616-1-git-send-email-paul.durrant@citrix.com> CC: Boris Ostrovsky , Juergen Gross From: David Vrabel Message-ID: <74e38f5a-6ec5-f828-e03e-070580706449@citrix.com> Date: Mon, 10 Oct 2016 11:16:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.3.0 MIME-Version: 1.0 In-Reply-To: <1476092625-14616-1-git-send-email-paul.durrant@citrix.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 673 Lines: 21 On 10/10/16 10:43, Paul Durrant wrote: > The Xen docs specify several flags which a guest can set to advertize > which values of the xenstore control/shutdown key it will recognize. > This patch adds code to write all the relevant feature-flag keys. [...] > static int setup_shutdown_watcher(void) > { > + static struct shutdown_handler *handler; > int err; > > + for (handler = &shutdown_handlers[0]; handler->command; handler++) { > + char *node; char node[20]; and avoid the allocation and resulting error path. As Juergen notes, the 'flag' field isn't used anywhere now. Can you please test your patches and verify the correct keys are being created? David