Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171AbcJJKj3 (ORCPT ); Mon, 10 Oct 2016 06:39:29 -0400 Received: from ozlabs.org ([103.22.144.67]:38941 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751516AbcJJKj2 (ORCPT ); Mon, 10 Oct 2016 06:39:28 -0400 From: Michael Ellerman To: Anton Blanchard Cc: Benjamin Herrenschmidt , Paul Mackerras , Nicholas Piggin , ravi.bangoria@linux.vnet.ibm.com, acme@redhat.com, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: perf TUI fails with "failed to process type: 64" In-Reply-To: <20161010211812.13eb89d5@kryten> References: <20161009121232.174915eb@kryten> <874m4k7q5s.fsf@concordia.ellerman.id.au> <20161010211812.13eb89d5@kryten> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Mon, 10 Oct 2016 21:39:25 +1100 Message-ID: <87r37o5vz6.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1163 Lines: 40 Anton Blanchard writes: >> > 14c00-14c00 g exc_virt_0x4c00_system_call >> ^ >> What's this? The address? If so it's wrong? > > Offset into the binary I think, there's one 64kB page of ELF gunk at > the start. Ah OK makes sense. >> So more digging required. > > Thanks for checking, it's starting to sound like a perf bug. Yeah possibly. I'll build an updated perf tomorrow and see if I can reproduce. As an aside, it looks like it would be easy to set the size with the new macro. Does the patch below help at all? The other thing Nick mentioned is we could set the type of those symbols to function, though that's not entirely correct. But it might help perf and probably wouldn't break anything else (that I can think of right now anyway). cheers diff --git a/arch/powerpc/include/asm/head-64.h b/arch/powerpc/include/asm/head-64.h index ab90c2fa1ea6..0e250d4eff44 100644 --- a/arch/powerpc/include/asm/head-64.h +++ b/arch/powerpc/include/asm/head-64.h @@ -122,6 +122,7 @@ name: .error "Fixed entry overflow"; \ .abort; \ .endif; \ + .size name, (. - name); \ . = ((end) - sname##_start); \