Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752249AbcJJMMA (ORCPT ); Mon, 10 Oct 2016 08:12:00 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:36126 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751963AbcJJML7 (ORCPT ); Mon, 10 Oct 2016 08:11:59 -0400 MIME-Version: 1.0 In-Reply-To: <1476052007-1148-1-git-send-email-chasemetzger15@gmail.com> References: <1476052007-1148-1-git-send-email-chasemetzger15@gmail.com> From: Vaibhav Agarwal Date: Mon, 10 Oct 2016 17:25:05 +0530 Message-ID: Subject: Re: [PATCH] drivers: staging: greybus: audio_codec.c: Fixed CHECKS for brace issues To: Chase Metzger Cc: Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1125 Lines: 28 On Mon, Oct 10, 2016 at 3:56 AM, Chase Metzger wrote: > Added braces to else statement where checkpatch complained. > > Signed-off-by: Chase Metzger > --- > drivers/staging/greybus/audio_codec.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c > index 8a0744b..1bdf849 100644 > --- a/drivers/staging/greybus/audio_codec.c > +++ b/drivers/staging/greybus/audio_codec.c > @@ -655,8 +655,10 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream) > ret = gb_audio_apbridgea_shutdown_rx(data->connection, > 0); > params->state = GBAUDIO_CODEC_STOP; > - } else > + } else { > ret = -EINVAL; > + } > + > if (ret) > dev_err_ratelimited(dai->dev, > "%s:Error during %s %s stream:%d\n", > -- > 2.1.4 > Reviewed-by: Vaibhav Agarwal