Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752277AbcJJMx2 convert rfc822-to-8bit (ORCPT ); Mon, 10 Oct 2016 08:53:28 -0400 Received: from smtpfb1-g21.free.fr ([212.27.42.9]:55667 "EHLO smtpfb1-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751917AbcJJMxZ (ORCPT ); Mon, 10 Oct 2016 08:53:25 -0400 Date: Mon, 10 Oct 2016 14:50:21 +0200 From: Jean-Francois Moine To: Maxime Ripard Cc: Corentin Labbe , mark.rutland@arm.com, andrew@lunn.ch, f.fainelli@gmail.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, wens@csie.org, robh+dt@kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 04/10] ARM: dts: sun8i-h3: Add dt node for the syscon control module Message-Id: <20161010145021.00586f772e3398833217796a@free.fr> In-Reply-To: <20161010123151.GI3462@lukather> References: <1475828757-926-1-git-send-email-clabbe.montjoie@gmail.com> <1475828757-926-5-git-send-email-clabbe.montjoie@gmail.com> <20161010123151.GI3462@lukather> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; armv7l-unknown-linux-gnueabihf) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1734 Lines: 56 On Mon, 10 Oct 2016 14:31:51 +0200 Maxime Ripard wrote: > Hi, > > On Fri, Oct 07, 2016 at 10:25:51AM +0200, Corentin Labbe wrote: > > This patch add the dt node for the syscon register present on the > > Allwinner H3. > > > > Only two register are present in this syscon and the only one useful is > > the one dedicated to EMAC clock. > > > > Signed-off-by: Corentin Labbe > > --- > > arch/arm/boot/dts/sun8i-h3.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi > > index 8a95e36..1101d2f 100644 > > --- a/arch/arm/boot/dts/sun8i-h3.dtsi > > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi > > @@ -140,6 +140,11 @@ > > #size-cells = <1>; > > ranges; > > > > + syscon: syscon@01c00000 { > > + compatible = "syscon"; > > It would be great to have a more specific compatible here in addition > to the syscon, like "allwinner,sun8i-h3-system-controller". The System Control area is just like the PRCM area: it would be simpler to define the specific registers in the associated drivers. Here, instead of the syscon node, plus + emac: ethernet@1c30000 { + compatible = "allwinner,sun8i-h3-emac"; + syscon = <&syscon>; + reg = <0x01c30000 0x104>; + interrupts = ; ... there would be no 'syscon' node and + emac: ethernet@1c30000 { + compatible = "allwinner,sun8i-h3-emac"; + syscon = <&syscon>; + reg = <0x01c30000 0x104>, /* EMAC */ + <0x01c00030 4>; /* system control */ + interrupts = ; ... -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/