Subject: Re: [PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute
 controls
To: Mark Brown <broonie@kernel.org>
References: <20160830202501.19323-1-dev@g0hl1n.net>
 <20160831092631.013c8170@g0hl1n.net> <20160909094645.64b7744a@g0hl1n.net>
 <20160909101719.GD27946@sirena.org.uk>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        eric@nelint.com, clemens.gruber@pqgruber.com, tiwai@suse.com,
        perex@perex.cz, lgirdwood@gmail.com
From: Richard Leitner <me@g0hl1n.net>
Message-ID: <4b11fbea-6a04-a157-4225-592326aa76bd@g0hl1n.net>
Date: Mon, 10 Oct 2016 14:52:38 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Icedove/45.2.0
MIME-Version: 1.0
In-Reply-To: <20160909101719.GD27946@sirena.org.uk>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1307
Lines: 35


On 09/09/2016 12:17 PM, Mark Brown wrote:
> On Fri, Sep 09, 2016 at 09:46:45AM +0200, Richard Leitner wrote:
>> Hi,
>> any comments, updates or ideas for improvement on that patch?
>>
>> On Wed, 31 Aug 2016 09:26:31 +0200
>> Richard Leitner <dev@g0hl1n.net> wrote:
>
> Please don't top post, reply in line with needed context.  This allows
> readers to readily follow the flow of conversation and understand what
> you are talking about and also helps ensure that everything in the
> discussion is being addressed.

Ok, thanks for that hint. I'm pretty new to this, therefore I hope I'll 
get everything right from now on.


>
> Please don't send content free pings and please allow a reasonable time
> for review.  People get busy, go on holiday, attend conferences and so
> on so unless there is some reason for urgency (like critical bug fixes)
> please allow at least a couple of weeks for review.  If there have been
> review comments then people may be waiting for those to be addressed.
> Sending content free pings just adds to the mail volume (if they are
> seen at all) and if something has gone wrong you'll have to resend the
> patches anyway.
>

So it's been a month now, is this a reasonable time to ping?

Although it's a pretty small change I don't want it to get lost...

regards,
Richard