Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752708AbcJJNOF (ORCPT ); Mon, 10 Oct 2016 09:14:05 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:34641 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752366AbcJJNNM (ORCPT ); Mon, 10 Oct 2016 09:13:12 -0400 MIME-Version: 1.0 In-Reply-To: <1475767268-14379-3-git-send-email-tomeu.vizoso@collabora.com> References: <1475767268-14379-1-git-send-email-tomeu.vizoso@collabora.com> <1475767268-14379-3-git-send-email-tomeu.vizoso@collabora.com> From: Emil Velikov Date: Mon, 10 Oct 2016 14:12:40 +0100 Message-ID: Subject: Re: [PATCH v11 2/4] drm: Add API for capturing frame CRCs To: Tomeu Vizoso Cc: "Linux-Kernel@Vger. Kernel. Org" , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Sean Paul , Daniel Vetter , Thierry Reding , linux-doc@vger.kernel.org, David Airlie , ML dri-devel , Jonathan Corbet Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2171 Lines: 62 On 6 October 2016 at 16:21, Tomeu Vizoso wrote: > Adds files and directories to debugfs for controlling and reading frame > CRCs, per CRTC: > > dri/0/crtc-0/crc > dri/0/crtc-0/crc/control > dri/0/crtc-0/crc/data > > Drivers can implement the set_crc_source callback() in drm_crtc_funcs to > start and stop generating frame CRCs and can add entries to the output > by calling drm_crtc_add_crc_entry. > > v2: > - Lots of good fixes suggested by Thierry. > - Added documentation. > - Changed the debugfs layout. > - Moved to allocate the entries circular queue once when frame > generation gets enabled for the first time. > v3: > - Use the control file just to select the source, and start and stop > capture when the data file is opened and closed, respectively. > - Make variable the number of CRC values per entry, per source. > - Allocate entries queue each time we start capturing as now there > isn't a fixed number of CRC values per entry. > - Store the frame counter in the data file as a 8-digit hex number. > - For sources that cannot provide useful frame numbers, place > XXXXXXXX in the frame field. > > v4: > - Build only if CONFIG_DEBUG_FS is enabled. > - Use memdup_user_nul. > - Consolidate calculation of the size of an entry in a helper. > - Add 0x prefix to hex numbers in the data file. > - Remove unnecessary snprintf and strlen usage in read callback. > > v5: > - Made the crcs array in drm_crtc_crc_entry fixed-size > - Lots of other smaller improvements suggested by Emil Velikov > > v7: > - Move definition of drm_debugfs_crtc_crc_add to drm_internal.h > > v8: > - Call debugfs_remove_recursive when we fail to create the minor > device > > v9: > - Register the debugfs directory for a crtc from > drm_crtc_register_all() > > v10: > - Don't let debugfs failures interrupt CRTC registration (Emil > Velikov) > > v11: > - Remove extra brace that broke compilation. Sorry! > > Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov Emil