Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752464AbcJJNrW (ORCPT ); Mon, 10 Oct 2016 09:47:22 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:45693 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752002AbcJJNrU (ORCPT ); Mon, 10 Oct 2016 09:47:20 -0400 Subject: Re: [PATCH v7 6/6] perf annotate: cross arch annotate support fixes for ARM To: Arnaldo Carvalho de Melo References: <1474472876-2706-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <1474472876-2706-7-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <20161005113406.GV7143@kernel.org> Cc: linux-kernel@vger.kernel.org, kim.phillips@arm.com, linuxppc-dev@lists.ozlabs.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, treeze.taeung@gmail.com, naveen.n.rao@linux.vnet.ibm.com, markus@trippelsdorf.de, namhyung@kernel.org, pawel.moll@arm.com, chris.ryder@arm.com, jolsa@kernel.org, mhiramat@kernel.org, Ravi Bangoria From: Ravi Bangoria Date: Mon, 10 Oct 2016 19:16:16 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20161005113406.GV7143@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16101013-8235-0000-0000-0000095D1590 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005886; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000186; SDB=6.00766465; UDB=6.00366598; IPR=6.00542587; BA=6.00004799; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012934; XFM=3.00000011; UTC=2016-10-10 13:46:27 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16101013-8236-0000-0000-00003584E849 Message-Id: <57FB9BA8.2050506@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-10_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610100232 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 853 Lines: 24 On Wednesday 05 October 2016 05:04 PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Sep 21, 2016 at 09:17:56PM +0530, Ravi Bangoria escreveu: >> From: Kim Phillips >> >> For ARM we remove the list that contains non-arm insns, and >> instead add more maintainable branch instruction regex logic. > This one looks ok and actually is in the direction of having facilities > for all arches, should've come as infrastructure that then gets used by > ARM and powerpc. This was authored by Kim and I didn't wanted to change that so I kept it at the end. I'm sending a cleanup patch that applies on top of this series. That patch moves most of arch specific stuff from util/annotate.c to util/annotate/.c. Please review it. Please pull this series if you are ok with that patch. Otherwise I'll respin entire series. Thanks -Ravi