Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752782AbcJJOAm (ORCPT ); Mon, 10 Oct 2016 10:00:42 -0400 Received: from canardo.mork.no ([148.122.252.1]:48477 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752047AbcJJOAk (ORCPT ); Mon, 10 Oct 2016 10:00:40 -0400 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Dan Carpenter Cc: Richard Weinberger , SF Markus Elfring , "linux-raid\@vger.kernel.org" , Christoph Hellwig , Guoqing Jiang , Jens Axboe , Mike Christie , Neil Brown , Shaohua Li , Tomasz Majchrzak , LKML , "kernel-janitors\@vger.kernel.org" , Julia Lawall Subject: Re: [PATCH 24/54] md/raid1: Improve another size determination in setup_conf() Organization: m References: <566ABCD9.1060404@users.sourceforge.net> <786843ef-4b6f-eb04-7326-2f6f5b408826@users.sourceforge.net> <9831fce9-d689-89e4-dec8-50cadcd13fdd@users.sourceforge.net> <20161010110050.GA5687@mwanda> Date: Mon, 10 Oct 2016 15:57:57 +0200 In-Reply-To: <20161010110050.GA5687@mwanda> (Dan Carpenter's message of "Mon, 10 Oct 2016 14:12:34 +0300") Message-ID: <87y41wqpay.fsf@miraculix.mork.no> User-Agent: Gnus/5.130015 (Ma Gnus v0.15) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9AE1KJC003228 Content-Length: 1009 Lines: 28 Dan Carpenter writes: > I am ignoring Markus patches and have told him that he should focus on > bug fixes. These patches don't add any value and regularly introduce > bugs. I think there should be a big fat warning in CodingStyle: THIS DOCUMENT DOES NOT APPLY TO ANY EXISTING KERNEL CODE. Preserving existing style is more important than any minor style issue anyway. Style changes for the only purpose of style change should be considered harmful and destructive behaviour. You'd think that is bloody obvious, but evidently it isn't. Not only are the untested, buggy, churning patches still being submitted - some of them are even applied! Adding such a statement will not prevent style changes, even changes to bring code more in line with CodingStyle, as long as the patches are part of some work of substance. E.g. cleaning up before fixing bugs. If you submit new code, then you can of course fix the style of any touched context. Oh well, I can dream.. Bjørn