Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753256AbcJJQTV (ORCPT ); Mon, 10 Oct 2016 12:19:21 -0400 Received: from mx2.suse.de ([195.135.220.15]:54856 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752462AbcJJQTT (ORCPT ); Mon, 10 Oct 2016 12:19:19 -0400 Date: Mon, 10 Oct 2016 18:18:21 +0200 From: Borislav Petkov To: Dave Hansen Cc: Nilay Vaish , Fenghua Yu , Thomas Gleixner , "H. Peter Anvin" , Ingo Molnar , Tony Luck , Peter Zijlstra , Stephane Eranian , Shaohua Li , David Carrillo-Cisneros , Ravi V Shankar , Sai Prakhya , Vikas Shivappa , linux-kernel , x86 Subject: Re: [PATCH v3 04/18] x86/intel_rdt: Feature discovery Message-ID: <20161010161821.izr3ow7m4bht2vaw@pd.tnic> References: <1475894763-64683-1-git-send-email-fenghua.yu@intel.com> <1475894763-64683-5-git-send-email-fenghua.yu@intel.com> <57FBBB68.4090008@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <57FBBB68.4090008@intel.com> User-Agent: NeoMutt/ (1.7.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 688 Lines: 17 On Mon, Oct 10, 2016 at 09:01:44AM -0700, Dave Hansen wrote: > While that isn't a horrible idea, it's also not something that we've > enforced at *all* in the past. Would you suggest that we do this only > for features in the generic CPUID leaves, or all features? There's no reason to do anything really: the 0x0... CPUID leaf is owned by Intel and 0x8... by AMD. So far, if AMD implements a feature in the Intel leaf, it sets the respective CPUID bit. So a feature can be present in multiple vendors. Thus you don't need the vendor name in the define. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --