Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753080AbcJJQ4W (ORCPT ); Mon, 10 Oct 2016 12:56:22 -0400 Received: from mail.kernel.org ([198.145.29.136]:59968 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752163AbcJJQ4V (ORCPT ); Mon, 10 Oct 2016 12:56:21 -0400 Date: Mon, 10 Oct 2016 13:56:16 -0300 From: Arnaldo Carvalho de Melo To: Ravi Bangoria Cc: "Naveen N. Rao" , linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, hekuang@huawei.com, jpoimboe@redhat.com, eranian@google.com, adrian.hunter@intel.com, mhiramat@kernel.org, pawel.moll@arm.com, chris.ryder@arm.com Subject: Re: [PATCH] perf annotate: Cleanup arch specific stuff Message-ID: <20161010165616.GM4809@kernel.org> References: <1474472876-2706-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <1476107942-9200-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <20161010162412.GK4809@kernel.org> <20161010163928.GA3816@naverao1-tp.localdomain> <57FBC698.6070303@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57FBC698.6070303@linux.vnet.ibm.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1197 Lines: 29 Em Mon, Oct 10, 2016 at 10:19:28PM +0530, Ravi Bangoria escreveu: > > > On Monday 10 October 2016 10:09 PM, Naveen N. Rao wrote: > > On 2016/10/10 01:24PM, Arnaldo Carvalho de Melo wrote: > >> Em Mon, Oct 10, 2016 at 07:29:02PM +0530, Ravi Bangoria escreveu: > >>> Move arch specific stuff from util/annotate.c to their respective > >>> files in util/annotate directory. > >>> > >>> No functionality changes. > >>> > >>> Signed-off-by: Ravi Bangoria > >>> --- > >>> tools/perf/util/Build | 1 + > >>> tools/perf/util/annotate.c | 259 +++---------------------------------- > >>> tools/perf/util/annotate.h | 23 ++++ > >>> tools/perf/util/annotate/Build | 3 + > >>> tools/perf/util/annotate/arm.c | 50 +++++++ > >>> tools/perf/util/annotate/powerpc.c | 63 +++++++++ > >>> tools/perf/util/annotate/x86.c | 107 +++++++++++++++ > >> We already have a per arch area: tools/perf/arch/ > > I think this was done to support cross-arch annotate similar to the > > remote unwind support with util/libunwind/ > > Yes, because tools/perf/arch/ will only include host arch code. Ok, thanks for clarifying. - Arnaldo