Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753481AbcJJRyw (ORCPT ); Mon, 10 Oct 2016 13:54:52 -0400 Received: from ud10.udmedia.de ([194.117.254.50]:35625 "EHLO mail.ud10.udmedia.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753105AbcJJRyk (ORCPT ); Mon, 10 Oct 2016 13:54:40 -0400 Date: Mon, 10 Oct 2016 19:54:27 +0200 From: Markus Trippelsdorf To: Namhyung Kim Cc: linux-kernel@vger.kernel.org Subject: Re: Scrolling down broken with "perf top --hierarchy" Message-ID: <20161010175427.GA8325@x4> References: <20161006163333.GC308@x4> <20161007011753.GA31113@sejong> <20161007035118.GA308@x4> <20161007042218.GE31113@sejong> <20161007043229.GB308@x4> <20161007045636.GC308@x4> <20161007050939.GD308@x4> <20161008112124.GA304@x4> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161008112124.GA304@x4> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3288 Lines: 79 On 2016.10.08 at 13:21 +0200, Markus Trippelsdorf wrote: > On 2016.10.07 at 07:09 +0200, Markus Trippelsdorf wrote: > > On 2016.10.07 at 06:56 +0200, Markus Trippelsdorf wrote: > > > On 2016.10.07 at 06:32 +0200, Markus Trippelsdorf wrote: > > > > On 2016.10.07 at 13:22 +0900, Namhyung Kim wrote: > > > > > On Fri, Oct 07, 2016 at 05:51:18AM +0200, Markus Trippelsdorf wrote: > > > > > > On 2016.10.07 at 10:17 +0900, Namhyung Kim wrote: > > > > > > > On Thu, Oct 06, 2016 at 06:33:33PM +0200, Markus Trippelsdorf wrote: > > > > > > > > Scrolling down is broken when using "perf top --hierarchy". > > > > > > > > When it starts up everything is OK and one can scroll up and down to all > > > > > > > > entries. But as further and further new entries get added to the list, > > > > > > > > scrolling down is blocked (at the position of the last entry that was > > > > > > > > shown directly after startup). > > > > > > > > > > > > > > I think below patch will fix the problem. Please check. > > > > > > > > > > > > Yes. It works fine now. Many thanks. > > > > > > > > > > Good. Can I add your Tested-by then? > > > > > > > > Sure. > > > > > > And BTW symbols are currently always cut off at 60 characters in > > > expanded entries. > > > > Hmm, no. Sometimes they are cut off, sometimes they are not. I haven't > > figured out what triggered this strange behavior. > > Here is an example: > > % echo $COLUMNS > 179 > % perf top --hierarchy > + 34.81% [kernel] > - 20.89% chrome > 0.51% [.] v8::internal::IncrementalMarking: > 0.43% [.] tc_malloc > 0.29% [.] sqlite3BtreeMovetoUnpacked > 0.28% [.] tc_free > 0.24% [.] v8::internal::BodyDescriptorBase: > 0.24% [.] sqlite3VdbeExec > 0.22% [.] v8::internal::MarkCompactCollecto > 0.19% [.] blink::SelectorChecker::checkOne > 0.19% [.] SkBlitRow::Color32 > 0.18% [.] SkBlitLCD16OpaqueRow_SSE2 > 0.17% [.] btreeInitPage.part.366 > 0.16% [.] blink::SelectorChecker::matchSele > 0.15% [.] blink::ElementRuleCollector::coll > 0.15% [.] blink::CSSTokenizer::consumeName > 0.14% [.] sqlite3GetVarint > 0.13% [.] operator new[] > 0.12% [.] FPDFAPI_inflate_fast > 0.11% [.] v8::internal::HeapObject::SizeFro > 0.09% [.] tracked_objects::ThreadData::Tall > ... To continue this monologue, perf doesn't even look at these entries. So some hists__calc_col_len() calls seem to be missing for the "perf top --hierarchy" case or hists__reset_col_len() is called too early or too often. Anyway, the following hack "fixes" the issue for me: diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c index b02992efb513..7e468fa56980 100644 --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c @@ -67,7 +67,7 @@ void hists__calc_col_len(struct hists *hists, struct hist_entry *h) * +3 accounts for ' y ' symtab origin info */ if (h->ms.sym) { - symlen = h->ms.sym->namelen + 4; + symlen = 200; if (verbose) symlen += BITS_PER_LONG / 4 + 2 + 3; hists__new_col_len(hists, HISTC_SYMBOL, symlen); -- Markus