Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752658AbcJJX1a (ORCPT ); Mon, 10 Oct 2016 19:27:30 -0400 Received: from vern.gendns.com ([206.190.152.46]:43194 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752422AbcJJX12 (ORCPT ); Mon, 10 Oct 2016 19:27:28 -0400 Subject: Re: [PATCH/RFT 08/12] ARM: davinci: register the usb20_phy clock on the SoC file To: ahaslam@baylibre.com, gregkh@linuxfoundation.org, robh+dt@kernel.org, nsekhar@ti.com, stern@rowland.harvard.edu, khilman@baylibre.com, sshtylyov@ru.mvista.com References: <1475858577-10366-1-git-send-email-ahaslam@baylibre.com> <1475858577-10366-9-git-send-email-ahaslam@baylibre.com> Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: David Lechner Message-ID: <383dd208-ff45-fde9-6500-ca12ec0ca805@lechnology.com> Date: Mon, 10 Oct 2016 18:27:49 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1475858577-10366-9-git-send-email-ahaslam@baylibre.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1195 Lines: 28 On 10/07/2016 11:42 AM, ahaslam@baylibre.com wrote: > From: Axel Haslam > > The usb20_phy clock needs to be registered for the driver to be able > to get and enable a clock. Currently the usb phy clocks are registered > form board files, which will not be called during a device tree based > boot. > > To be able to probe correctly usb form a device tree boot, register > the usb phy clocks form the SoC specific init. > > Unfourtunatly, davinci does not have proper clock support on device tree > yet, so by registering the clock form de SoC specific file we are > forced to hardcode the parent clock, and cannot select refclkin as > parent for any of the phy clocks of the da850 family. FYI, I have started working on the clocks as well if you want to take it and run with it. https://github.com/dlech/ev3dev-kernel/compare/9d6b50cde34b51309c74d97c26b1430c7ff6aa0f...d02084598785c369fdb23884171cbbec4fef77b0 (Ignore the ev3dev commit stuck in the middle there.) > > As none of the current da850 based boards currently in mainline use > refclkin as source. I guess we can live with this limitation until clocks > are correctly represented through CCF/device tree. >