Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752761AbcJJXdH (ORCPT ); Mon, 10 Oct 2016 19:33:07 -0400 Received: from vern.gendns.com ([206.190.152.46]:43408 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752252AbcJJXdE (ORCPT ); Mon, 10 Oct 2016 19:33:04 -0400 Subject: Re: [PATCH/RFT 09/12] usb: host: ohci-da8xx: Add devicetree bindings documentation To: ahaslam@baylibre.com, gregkh@linuxfoundation.org, robh+dt@kernel.org, nsekhar@ti.com, stern@rowland.harvard.edu, khilman@baylibre.com, sshtylyov@ru.mvista.com References: <1475858577-10366-1-git-send-email-ahaslam@baylibre.com> <1475858577-10366-10-git-send-email-ahaslam@baylibre.com> Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: David Lechner Message-ID: <33e5d2ff-4d39-2d84-670c-5cac12518945@lechnology.com> Date: Mon, 10 Oct 2016 18:33:25 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1475858577-10366-10-git-send-email-ahaslam@baylibre.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1859 Lines: 54 On 10/07/2016 11:42 AM, ahaslam@baylibre.com wrote: > From: Axel Haslam > > This patch documents the device tree bindings required for > the ohci controller found in TI da8xx family of SoC's > > Signed-off-by: Axel Haslam > --- > .../devicetree/bindings/usb/ohci-da8xx.txt | 32 ++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/ohci-da8xx.txt > > diff --git a/Documentation/devicetree/bindings/usb/ohci-da8xx.txt b/Documentation/devicetree/bindings/usb/ohci-da8xx.txt > new file mode 100644 > index 0000000..e954ce5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/ohci-da8xx.txt > @@ -0,0 +1,32 @@ > +DA8XX USB OHCI controller > + > +Required properties: > + > + - compatible: Should be "ti,da830-ohci" > + - reg: Should contain one register range i.e. start and length > + - interrupts: Description of the interrupt line > + - phys: Phandle for the PHY device > + - phy-names: Should be "usb-phy" > + If these are required, shouldn't they say "Must" instead of "Should"? > +Optional properties: > + - vbus-gpio: If present, specifies a gpio that needs to be > + activated for the bus to be powered. > + - oci-gpio: If present, specifies a gpio that needs to be > + activated for the overcurrent detection. > + - power_on_delay: Power On to Power Good time - in ms. > + > +Example for omap138-lck: > + > +usb_phy: usb-phy { > + compatible = "ti,da830-usb-phy"; > + #phy-cells = <1>; > + status = "disabled"; > +}; > +usb11: usb11@0225000 { > + compatible = "ti,da830-ohci"; > + reg = <0x225000 0x1000>; > + interrupts = <59>; > + phys = <&usb_phy 1>; > + phy-names = "usb-phy"; > + status = "disabled"; > +}; >