Message-ID: <1476153632.477.2.camel@mtksdaap41>
Subject: Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver
From: Horng-Shyang Liao <hs.liao@mediatek.com>
To: Jassi Brar <jaswinder.singh@linaro.org>
CC: CK Hu <ck.hu@mediatek.com>, Daniel Kurtz <djkurtz@chromium.org>,
        "Monica Wang" <monica.wang@mediatek.com>,
        Jiaguang Zhang <jiaguang.zhang@mediatek.com>,
        Nicolas Boichat <drinkcat@chromium.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        cawa cheng <cawa.cheng@mediatek.com>,
        Bibby Hsieh <bibby.hsieh@mediatek.com>, YT Shen <yt.shen@mediatek.com>,
        Damon Chu <damon.chu@mediatek.com>,
        Devicetree List <devicetree@vger.kernel.org>,
        Sascha Hauer <kernel@pengutronix.de>,
        "Daoyuan Huang" <daoyuan.huang@mediatek.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Glory Hung <glory.hung@mediatek.com>, Rob Herring <robh+dt@kernel.org>,
        <linux-mediatek@lists.infradead.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        <srv_heupstream@mediatek.com>, Josh-YC Liu <josh-yc.liu@mediatek.com>,
        lkml <linux-kernel@vger.kernel.org>,
        Dennis-YC Hsieh <dennis-yc.hsieh@mediatek.com>,
        Philipp Zabel <p.zabel@pengutronix.de>, <hs.liao@mediatek.com>
Date: Tue, 11 Oct 2016 10:40:32 +0800
In-Reply-To: <CAJe_ZheptRQSmQp2gagqUyXqkOpi1qaTo8QPDTFpQ-+62B6kUw@mail.gmail.com>
References: <1473039885-24009-1-git-send-email-hs.liao@mediatek.com>
         <1473039885-24009-3-git-send-email-hs.liao@mediatek.com>
         <1475204778.13398.28.camel@mtksdaap41>
         <1475225778.25044.35.camel@mtksdaap41>
         <1475226691.13398.35.camel@mtksdaap41> <1475228829.3658.1.camel@mtksdaap41>
         <1475636064.21937.25.camel@mtksdaap41>
         <CAJe_ZhcXw1-MOEiiix5VTtKEVr9Z23s_OyikboDYCd0RQwS5pg@mail.gmail.com>
         <1475670705.335.27.camel@mtksdaap41>
         <CAJe_ZheeEe0xEj733pxr4q=-YzxKHgRM4MMPDJNHa9uRC9Q2zA@mail.gmail.com>
         <1475758897.4102.31.camel@mtksdaap41>
         <CAJe_ZheptRQSmQp2gagqUyXqkOpi1qaTo8QPDTFpQ-+62B6kUw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1402
Lines: 31

On Thu, 2016-10-06 at 18:40 +0530, Jassi Brar wrote:
> On 6 October 2016 at 18:31, Horng-Shyang Liao <hs.liao@mediatek.com> wrote:
> 
> > Back to our original statement, we need to flush all tasks to queue
> > in GCE HW; i.e. we need to use mbox_client_txdone after
> > mbox_send_message, or send tx_done once mailbox controller receive
> > message (task). However, we still need a way to notice done tasks to
> > clients. Currently, we don't have a good way to call callback in mailbox
> > framework. Therefore, CMDQ driver has its owner callback functions.
> >
> mbox_client_txdone() is called by the client driver when only it knows
> the messages has been transmitted (i.e your submitted tasks are done).
> Obviously the client driver should do any callbacks to its users
> upstream.

Hi Jassi,

In current CMDQ driver, mbox_client_txdone() is called to prevent the
blocking of chan->active_req. It is not the real point of CMDQ task
done, so the client driver cannot do any callbacks to its user upstream.

(1) If we don't use mbox_client_txdone(), could you tell us an
    alternative way to prevent the blocking of chan->active_req?
    And then we can use tx_done when CMDQ task is relly done.
(2) If we use mbox_client_txdone() to prevent the blocking of
    chan->active_req, could CMDQ driver just uses self-defined callback
    function to notice client driver CMDQ task done?

Thanks,
HS