Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752395AbcJKIPn (ORCPT ); Tue, 11 Oct 2016 04:15:43 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:33785 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751985AbcJKIPk (ORCPT ); Tue, 11 Oct 2016 04:15:40 -0400 Date: Tue, 11 Oct 2016 10:15:34 +0200 From: Daniel Vetter To: Shyam Saini Cc: Patrik Jakobsson , linux-kernel , dri-devel Subject: Re: [PATCH 1/1] gpu: drm: gma500: Use vma_pages() Message-ID: <20161011081534.GY20761@phenom.ffwll.local> Mail-Followup-To: Shyam Saini , Patrik Jakobsson , linux-kernel , dri-devel References: <1476054436-9378-1-git-send-email-mayhs11saini@gmail.com> <1476064367.14200.0.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1476064367.14200.0.camel@gmail.com> X-Operating-System: Linux phenom 4.6.0-1-amd64 User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1902 Lines: 60 On Mon, Oct 10, 2016 at 07:22:47AM +0530, Shyam Saini wrote: > On Mon, 2016-10-10 at 01:46 +0200, Patrik Jakobsson wrote: > > On Mon, Oct 10, 2016 at 1:07 AM, Shyam Saini > > wrote: > > > > > > Replace explicit computation of vma page count by a call to > > > vma_pages() > > Hi, I already have this patch in the "queue" from: > > Muhammad Falak R Wani > > > > Will include that one when I get around to sending out a PR. Since the merge window is pretty much done I've applied this one here to drm-misc to make sure it wont get lost. -Daniel > > > > Thanks > > Patrik > > > > > > > > > > > Signed-off-by: Shyam Saini > > > --- > > > ?drivers/gpu/drm/gma500/framebuffer.c | 2 +- > > > ?1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/gma500/framebuffer.c > > > b/drivers/gpu/drm/gma500/framebuffer.c > > > index 3a44e70..0fde850 100644 > > > --- a/drivers/gpu/drm/gma500/framebuffer.c > > > +++ b/drivers/gpu/drm/gma500/framebuffer.c > > > @@ -124,7 +124,7 @@ static int psbfb_vm_fault(struct vm_area_struct > > > *vma, struct vm_fault *vmf) > > > ????????unsigned long phys_addr = (unsigned long)dev_priv- > > > >stolen_base + > > > ??????????????????????????????????psbfb->gtt->offset; > > > > > > -???????page_num = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > > > +???????page_num = vma_pages(vma); > > > ????????address = (unsigned long)vmf->virtual_address - (vmf->pgoff > > > << PAGE_SHIFT); > > > > > > ????????vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); > > > -- > > > 2.7.4 > > > > > No issue. > > Thanks > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch