Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752648AbcJKJSO (ORCPT ); Tue, 11 Oct 2016 05:18:14 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:27107 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752647AbcJKJSG (ORCPT ); Tue, 11 Oct 2016 05:18:06 -0400 Subject: Re: [PATCH 5/6] clk: stm32f469: Add QSPI clock To: Rob Herring References: <1475245509-6487-1-git-send-email-gabriel.fernandez@st.com> <1475245509-6487-6-git-send-email-gabriel.fernandez@st.com> <20161008205003.GB17455@rob-hp-laptop> CC: Mark Rutland , Russell King , Maxime Coquelin , Alexandre Torgue , Michael Turquette , Stephen Boyd , , , , , , , From: Gabriel Fernandez Message-ID: <61b117b7-1a30-f433-872a-c9087ba41fc1@st.com> Date: Tue, 11 Oct 2016 11:17:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161008205003.GB17455@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.1.80] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-11_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1736 Lines: 43 Hi Rob, Thanks for reviewing On 10/08/2016 10:50 PM, Rob Herring wrote: > On Fri, Sep 30, 2016 at 04:25:08PM +0200, gabriel.fernandez@st.com wrote: >> From: Gabriel Fernandez >> >> This patch adds the QSPI clock for stm32f469 discovery board. >> The gate mapping is a little bit different from stm32f429 soc. >> >> Signed-off-by: Gabriel Fernandez >> --- >> .../devicetree/bindings/clock/st,stm32-rcc.txt | 4 +- >> drivers/clk/clk-stm32f4.c | 173 ++++++++++++++++++--- >> 2 files changed, 158 insertions(+), 19 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/clock/st,stm32-rcc.txt b/Documentation/devicetree/bindings/clock/st,stm32-rcc.txt >> index fee3205..eace3de 100644 >> --- a/Documentation/devicetree/bindings/clock/st,stm32-rcc.txt >> +++ b/Documentation/devicetree/bindings/clock/st,stm32-rcc.txt >> @@ -8,7 +8,9 @@ Please also refer to clock-bindings.txt in this directory for common clock >> controller binding usage. >> >> Required properties: >> -- compatible: Should be "st,stm32f42xx-rcc" >> +- compatible: Should be: >> + "st,stm32f42xx-rcc" >> + "st,stm32f46xx-rcc" > Generally, we don't use wildcards in compatible strings. I know there's > lots of part numbers of stm32 parts which I guess are often same die > with different fusing or package. Your compatible strings should be at > least specific enough to identify parts that are really different die. okay i will propose "st,stm32f469-rcc" if no one is against. BR Gabriel > >> - reg: should be register base and length as documented in the >> datasheet >> - #clock-cells: 2, device nodes should specify the clock in their "clocks"