Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752858AbcJKJZR (ORCPT ); Tue, 11 Oct 2016 05:25:17 -0400 Received: from mga03.intel.com ([134.134.136.65]:9842 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752514AbcJKJZN (ORCPT ); Tue, 11 Oct 2016 05:25:13 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,476,1473145200"; d="scan'208";a="771236355" Subject: Re: [PATCH v2] sdhci-esdhc-imx: Correct two register accesses To: Aaron Brice , ulf.hansson@linaro.org, aisheng.dong@nxp.com References: <1476124792-18441-1-git-send-email-aaron.brice@datasoft.com> Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dave Russell From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <4e944cda-05c6-0515-c98d-e90600f63541@intel.com> Date: Tue, 11 Oct 2016 12:18:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1476124792-18441-1-git-send-email-aaron.brice@datasoft.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 702 Lines: 16 On 10/10/16 21:39, Aaron Brice wrote: > - The DMA error interrupt bit is in a different position as > compared to the sdhci standard. This is accounted for in > many cases, but not handled in the case of clearing the > INT_STATUS register by writing a 1 to that location. > - The HOST_CONTROL register is very different as compared to > the sdhci standard. This is accounted for in the write > case, but not when read back out (which it is in the sdhci > code). > > Signed-off-by: Dave Russell > Signed-off-by: Aaron Brice > Acked-by: Dong Aisheng Acked-by: Adrian Hunter