Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753403AbcJKNRn (ORCPT ); Tue, 11 Oct 2016 09:17:43 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:35051 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751592AbcJKNRj (ORCPT ); Tue, 11 Oct 2016 09:17:39 -0400 Subject: Re: [PATCH v4 5/5] mm: enable CONFIG_MOVABLE_NODE on non-x86 arches To: Reza Arbab , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Rob Herring , Frank Rowand , Andrew Morton References: <1475778995-1420-1-git-send-email-arbab@linux.vnet.ibm.com> <1475778995-1420-6-git-send-email-arbab@linux.vnet.ibm.com> Cc: Bharata B Rao , Nathan Fontenot , Stewart Smith , Alistair Popple , "Aneesh Kumar K.V" , Tang Chen , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-mm@kvack.org From: Balbir Singh Message-ID: <6d781236-3f2a-8fe6-682f-efa2c01bf429@gmail.com> Date: Wed, 12 Oct 2016 00:17:31 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1475778995-1420-6-git-send-email-arbab@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1109 Lines: 36 On 07/10/16 05:36, Reza Arbab wrote: > To support movable memory nodes (CONFIG_MOVABLE_NODE), at least one of > the following must be true: > > 1. We're on x86. This arch has the capability to identify movable nodes > at boot by parsing the ACPI SRAT, if the movable_node option is used. > > 2. Our config supports memory hotplug, which means that a movable node > can be created by hotplugging all of its memory into ZONE_MOVABLE. > > Fix the Kconfig definition of CONFIG_MOVABLE_NODE, which currently > recognizes (1), but not (2). > > Signed-off-by: Reza Arbab > --- > mm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index be0ee11..5d0818f 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -153,7 +153,7 @@ config MOVABLE_NODE > bool "Enable to assign a node which has only movable memory" > depends on HAVE_MEMBLOCK > depends on NO_BOOTMEM > - depends on X86_64 > + depends on X86_64 || MEMORY_HOTPLUG > depends on NUMA > default n > help > Acked-by: Balbir Singh