MIME-Version: 1.0
In-Reply-To: <CAGXu5jK--iZCVpQhFwWC2wU8yF-uot_zemtC8n7LxysFBthHJg@mail.gmail.com>
References: <1475904515-24970-1-git-send-email-joelaf@google.com>
 <1475904515-24970-4-git-send-email-joelaf@google.com> <CAGXu5jK--iZCVpQhFwWC2wU8yF-uot_zemtC8n7LxysFBthHJg@mail.gmail.com>
From: Joel Fernandes <joelaf@google.com>
Date: Tue, 11 Oct 2016 07:46:38 -0700
Message-ID: <CAJWu+oquafxsqo4VX3QwA3Fn4d13Y5ti7QWUek-LmMP1HPPSsg@mail.gmail.com>
Subject: Re: [PATCH 3/7] pstore: Remove case of PSTORE_TYPE_PMSG write using
 deprecated function
To: Kees Cook <keescook@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Anton Vorontsov <anton@enomsg.org>, Colin Cross <ccross@android.com>,
        Tony Luck <tony.luck@intel.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 588
Lines: 14

On Mon, Oct 10, 2016 at 4:52 PM, Kees Cook <keescook@chromium.org> wrote:
> On Fri, Oct 7, 2016 at 10:28 PM, Joel Fernandes <joelaf@google.com> wrote:
>> PMSG now uses ramoops_pstore_write_buf_user instead of ramoops_pstore_write_buf
>> Remove the case where we check PSTORE_TYPE_PMSG case.
>
> Ah yeah, good point. Can you actually improve this to add a
> ratelimited WARN() to both _write_buf and write_buf_user when an
> unhandled type is encountered?

Sure, I'll add that. I'll also use the kcalloc as you suggest in the
other thread and add module parameter, DT entry.

Thanks,
Joel