Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754069AbcJKRC2 (ORCPT ); Tue, 11 Oct 2016 13:02:28 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:43160 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753169AbcJKRC1 (ORCPT ); Tue, 11 Oct 2016 13:02:27 -0400 Date: Tue, 11 Oct 2016 11:01:43 -0600 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Peter Huewe , Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH 1/3] tpm_crb: map locality registers Message-ID: <20161011170143.GC6881@obsidianresearch.com> References: <1476177787-15003-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1476177787-15003-3-git-send-email-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476177787-15003-3-git-send-email-jarkko.sakkinen@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1380 Lines: 40 On Tue, Oct 11, 2016 at 12:23:04PM +0300, Jarkko Sakkinen wrote: > In order to provide access to locality registers, this commits adds > mapping of the head of the CRB registers, which are located right > before the control area. I think you should squash this into the prior patch, no sense in changing all these lines twice But looks better to me. > - priv->cca = crb_map_res(dev, priv, &io_res, buf->control_address, > - sizeof(struct crb_control_area)); > - if (IS_ERR(priv->cca)) > - return PTR_ERR(priv->cca); > + if (priv->flags & CRB_FL_CRB_START) { > + priv->regs_h = crb_map_res(dev, priv, &io_res, io_res.start, > + sizeof(struct crb_regs_head)); > + if (IS_ERR(priv->regs_h)) > + return PTR_ERR(priv->regs_h); > + } > + > + priv->regs_t = crb_map_res(dev, priv, &io_res, buf->control_address, > + sizeof(struct crb_regs_tail)); > + if (IS_ERR(priv->regs_t)) > + return PTR_ERR(priv->regs_t); So.. The ACPI IO region starts at the head area and continues to include the control area, as one nice sane region - except for some older stuff that puts the control area outside the ACPI IO region? That makes a lot more sense.. Maybe chuck in a if (priv->flags & CRB_FL_CRB_START) { if (buf->control_address != io_res.start + sizeof(struct crb_regs_head)) dev_warn(dev, FIRMWARE_BUG "Bad ACPI memory layout") Jason