Date: Tue, 11 Oct 2016 19:22:29 +0200
From: Michal Hocko <mhocko@kernel.org>
To: zijun_hu <zijun_hu@zoho.com>
Cc: tj@kernel.org, akpm@linux-foundation.org, zijun_hu@htc.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org, cl@linux.com
Subject: Re: [RFC PATCH 1/1] mm/percpu.c: fix memory leakage issue when
 allocate a odd alignment area
Message-ID: <20161011172228.GA30403@dhcp22.suse.cz>
References: <bc3126cd-226d-91c7-d323-48881095accf@zoho.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bc3126cd-226d-91c7-d323-48881095accf@zoho.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 643
Lines: 16

On Tue 11-10-16 21:24:50, zijun_hu wrote:
> From: zijun_hu <zijun_hu@htc.com>
> 
> the LSB of a chunk->map element is used for free/in-use flag of a area
> and the other bits for offset, the sufficient and necessary condition of
> this usage is that both size and alignment of a area must be even numbers
> however, pcpu_alloc() doesn't force its @align parameter a even number
> explicitly, so a odd @align maybe causes a series of errors, see below
> example for concrete descriptions.

Is or was there any user who would use a different than even (or power of 2)
alighment? If not is this really worth handling?

-- 
Michal Hocko
SUSE Labs