Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753423AbcJKRts (ORCPT ); Tue, 11 Oct 2016 13:49:48 -0400 Received: from dg.advantech.com ([71.4.62.2]:37290 "EHLO dg.advantech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752978AbcJKRtl (ORCPT ); Tue, 11 Oct 2016 13:49:41 -0400 X-Haraka-RcptSummary: valid=0 invalid=0 unverified=0 relay=11 norelay=0 X-Haraka-Relay: true From: "Ken.Lin" To: Fabio Estevam CC: "shawnguo@kernel.org" , "kernel@pengutronix.de" , "sboyd@codeaurora.org" , "mturquette@baylibre.com" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Peter.Stretz" , "Peter.Chiang" , Akshay Bhat , Jason Moss , "emil@limesaudio.com" Date: Tue, 11 Oct 2016 10:49:33 -0700 Subject: RE: The possible regression in kernel 4.8 - clk: imx: correct AV PLL rate formula Thread-Topic: The possible regression in kernel 4.8 - clk: imx: correct AV PLL rate formula Thread-Index: AdIgKrJwXQQBYk7qTtKvsz3FhePKZADvLEAg In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-Haraka-Syntax: mail_case=upper mail_leading_spaces=N mail_trailing_spaces=N mail_missing_brackets=N rcpt_case=upper rcpt_leading_spaces=N rcpt_missing_brackets=N rcpt_trailing_spaces=N X-Haraka-GeoIP-Received: 172.21.1.62:UNKNOWN X-Haraka-HostID: 172.21.1.62 X-Haraka-Domain-Info: domain="advantech.com" last_update=3197 primary_ns="ns0.dnsmadeeasy.com" serial=2008011098 refresh=43200 retry=3600 expiration=1209600 minimum=180 flags="" X-Haraka-Watermark: reply:WM!8b5ef465717800ac4466674b98bb32450dc231d955cd4979ca96fd54828a7c3af7de5f376015ebf046c75f20677161c6!@dgg.advantech.com References: <03B5A3CA1724CE4EAC32B27E39292A677FC5A390AE@AUSMAIL1.AUS.ADVANTECH.CORP> <03B5A3CA1724CE4EAC32B27E39292A677FC5A39613@AUSMAIL1.AUS.ADVANTECH.CORP> Message-Id: X-ADVANTECH-COM-MailScanner-Information: Please contact the postmaster@advantech.com for more information X-ADVANTECH-COM-MailScanner-ID: u9B7Rm9Y023256 X-ADVANTECH-COM-MailScanner: Found to be clean X-ADVANTECH-COM-MailScanner-SpamCheck: X-ADVANTECH-COM-MailScanner-From: ken.lin@advantech.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u9BHoKmU008884 Content-Length: 5227 Lines: 101 Hi Fabio, > -----Original Message----- > From: Fabio Estevam [mailto:festevam@gmail.com] > Sent: Thursday, October 6, 2016 4:38 PM > To: Ken.Lin > Cc: shawnguo@kernel.org; kernel@pengutronix.de; sboyd@codeaurora.org; > mturquette@baylibre.com; linux-arm-kernel@lists.infradead.org; linux- > clk@vger.kernel.org; linux-kernel@vger.kernel.org; Peter.Stretz; Peter.Chiang; > Akshay Bhat; Jason Moss; emil@limesaudio.com > Subject: Re: The possible regression in kernel 4.8 - clk: imx: correct AV PLL rate > formula > > Hi Ken, > > On Thu, Oct 6, 2016 at 8:26 PM, Ken.Lin wrote: > > Hi, > > > > We found a possible regression issue (not seen in kernel 4.7-stable), which has > to do with the new NXP commit ba7f4f557eb67ee21c979c8539dc1886f5d5341c > when we did a DP test (1920x1080@60) with clock source PLL5. > > The DP desired pixel clock (148.5MHz that is calculated from the input of PLL > output frequency) would be correct again when we reverted this commit. > > Could you please help check if the commit has the side effect since it would > have impacts on our on-going project when it requires moving from kernel 4.7 > to kernel 4.8 or newer version? > > > > Please check the following URL for the details > > https://www.dropbox.com/s/7wc5jdp8unlsiob/possible_regression_for_clk_ > > imx_correct_VL_PLL_rate_formula.pdf?dl=0 > > Do these patches from Emil fix the issue? > > http://www.spinics.net/lists/arm-kernel/msg535204.html > > and > > http://www.spinics.net/lists/arm-kernel/msg535203.html > > Thanks With the patches applied, the pixel clock (148500000 required for 1920x1080@60) is correct as we checked in kernel 4.7 and the actual measurement result looked good as we expected. I think the patches should fix the issue. Ref: /sys/kernel/debug/clk/clk_summary pll5 1 1 1039500000 0 0 pll5_bypass 1 1 1039500000 0 0 pll5_video 1 1 1039500000 0 0 pll5_post_div 1 1 519750000 0 0 pll5_video_div 2 2 519750000 0 0 ipu2_di1_pre_sel 0 0 519750000 0 0 ipu2_di1_pre 0 0 173250000 0 0 ipu2_di1_sel 0 0 173250000 0 0 ipu2_di1 0 0 173250000 0 0 ipu2_di0_pre_sel 0 0 519750000 0 0 ipu2_di0_pre 0 0 173250000 0 0 ldb_di1_sel 1 1 519750000 0 0 ldb_di1_div_3_5 1 1 148500000 0 0 ldb_di1_podf 1 1 148500000 0 0 ldb_di1 2 2 148500000 0 0 ipu2_di0_sel 1 1 148500000 0 0 ipu2_di0 1 1 148500000 0 0 ldb_di0_sel 1 1 519750000 0 0 ldb_di0_div_3_5 1 1 148500000 0 0 ldb_di0_podf 1 1 148500000 0 0 ldb_di0 1 1 148500000 0 0 Ref: kernel debug messages [ 113.848959] imx-ipuv3-crtc imx-ipuv3-crtc.6: ipu_crtc_mode_set_nofb: mode->hdisplay: 1920 [ 113.857201] imx-ipuv3-crtc imx-ipuv3-crtc.6: ipu_crtc_mode_set_nofb: mode->vdisplay: 1080 [ 113.865421] imx-ipuv3-crtc imx-ipuv3-crtc.6: ipu_crtc_mode_set_nofb: attached to encoder types 0x8 [ 113.874483] imx-ipuv3 2800000.ipu: disp 0: panel size = 1920 x 1080 [ 113.880803] imx-ipuv3 2800000.ipu: Clocks: IPU 264000000Hz DI 75833334Hz Needed 148500000Hz [ 113.889252] imx-ipuv3 2800000.ipu: Want 148500000Hz IPU 264000000Hz DI 75833334Hz using DI, 75833334Hz [ 113.898768] imx-ldb 2000000.aips-bus:ldb@020e0008: imx_ldb_set_clock: now: 227500000 want: 519750000 [ 113.908018] imx-ldb 2000000.aips-bus:ldb@020e0008: imx_ldb_set_clock after: 519750000 [ 113.915886] imx-ldb 2000000.aips-bus:ldb@020e0008: imx_ldb_set_clock: now: 148500000 want: 148500000 [ 113.925050] imx-ldb 2000000.aips-bus:ldb@020e0008: imx_ldb_set_clock after: 148500000 [ 113.932928] imx-ldb 2000000.aips-bus:ldb@020e0008: imx_ldb_set_clock: now: 519750000 want: 519750000 [ 113.942096] imx-ldb 2000000.aips-bus:ldb@020e0008: imx_ldb_set_clock after: 519750000 [ 113.949938] imx-ldb 2000000.aips-bus:ldb@020e0008: imx_ldb_set_clock: now: 148500000 want: 148500000 [ 113.959104] imx-ldb 2000000.aips-bus:ldb@020e0008: imx_ldb_set_clock after: 148500000 > > -- > This message has been scanned for viruses and dangerous content by > MailScanner, and is believed to be clean. Thank you -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.