Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753085AbcJKSKJ (ORCPT ); Tue, 11 Oct 2016 14:10:09 -0400 Received: from mga01.intel.com ([192.55.52.88]:53851 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752190AbcJKSKI (ORCPT ); Tue, 11 Oct 2016 14:10:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,330,1473145200"; d="scan'208";a="1052439795" Date: Tue, 11 Oct 2016 21:09:32 +0300 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: Nayna , Peter Huewe , Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH RESEND 2/3] tpm: replace dynamically allocated bios_dir with a static array Message-ID: <20161011180932.GA6900@intel.com> References: <1475349926-476-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1475349926-476-3-git-send-email-jarkko.sakkinen@linux.intel.com> <57FBE39B.2030301@linux.vnet.ibm.com> <20161011112315.GB21688@intel.com> <20161011165355.GB6881@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161011165355.GB6881@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 881 Lines: 29 On Tue, Oct 11, 2016 at 10:53:55AM -0600, Jason Gunthorpe wrote: > On Tue, Oct 11, 2016 at 02:23:15PM +0300, Jarkko Sakkinen wrote: > > > >+ chip->bios_dir[cnt] = > > > > securityfs_create_file("ascii_bios_measurements", > > > >- S_IRUSR | S_IRGRP, tpm_dir, > > > >+ S_IRUSR | S_IRGRP, chip->bios_dir[0], > > > > (void *)&tpm_ascii_b_measurments_seqops, > > > > &tpm_bios_measurements_ops); > > > > >+ if (is_bad(chip->bios_dir[cnt])) > > > >+ goto err; > > > > >+err: > > > >+ chip->bios_dir[cnt] = NULL; > > > > > > The updated patch looks fine. > > > Just, I am not sure if NULL assignment is needed. > > > > It's not needed. > > It is required to switch an ERR_PTR to NULL, see is_bad() > > The original version that used a counter in chip did not need it. Oops, sorry. I added it back. Thanks for pointing this out. > Jason /Jarkko