Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754128AbcJKS33 (ORCPT ); Tue, 11 Oct 2016 14:29:29 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:49890 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753397AbcJKS32 (ORCPT ); Tue, 11 Oct 2016 14:29:28 -0400 Date: Tue, 11 Oct 2016 12:29:22 -0600 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: g@intel.com, Peter Huewe , Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH 1/3] tpm_crb: map locality registers Message-ID: <20161011182922.GB20253@obsidianresearch.com> References: <1476177787-15003-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1476177787-15003-3-git-send-email-jarkko.sakkinen@linux.intel.com> <20161011170143.GC6881@obsidianresearch.com> <20161011182100.GC6900@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161011182100.GC6900@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 738 Lines: 19 On Tue, Oct 11, 2016 at 09:21:00PM +0300, Jarkko Sakkinen wrote: > On Tue, Oct 11, 2016 at 11:01:43AM -0600, Jason Gunthorpe wrote: > > On Tue, Oct 11, 2016 at 12:23:04PM +0300, Jarkko Sakkinen wrote: > > > In order to provide access to locality registers, this commits adds > > > mapping of the head of the CRB registers, which are located right > > > before the control area. > > > > I think you should squash this into the prior patch, no sense in > > changing all these lines twice > > > > But looks better to me. > > So... do you suggest to squash with request/reliquish locality stuff? > Just checking because this is 1/3 :) Hm, maybe my mailer went wrong, but I saw the original patch right before this one.. Never mind Jason