Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754094AbcJKVz0 (ORCPT ); Tue, 11 Oct 2016 17:55:26 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:42893 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752560AbcJKVzY (ORCPT ); Tue, 11 Oct 2016 17:55:24 -0400 To: Subhash Jadavani Cc: vinholikatti@gmail.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org (open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER), linux-kernel@vger.kernel.org (open list) Subject: Re: [RESEND PATCH v3] scsi: ufshcd: fix possible unclocked register access From: "Martin K. Petersen" Organization: Oracle Corporation References: <1475815702-8624-1-git-send-email-subhashj@codeaurora.org> Date: Tue, 11 Oct 2016 17:55:16 -0400 In-Reply-To: <1475815702-8624-1-git-send-email-subhashj@codeaurora.org> (Subhash Jadavani's message of "Thu, 6 Oct 2016 21:48:22 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 641 Lines: 15 >>>>> "Subhash" == Subhash Jadavani writes: Subhash> Vendor specific setup_clocks callback may require the clocks Subhash> managed by ufshcd driver to be ON. So if the vendor specific Subhash> setup_clocks callback is called while the required clocks are Subhash> turned off, it could result into unclocked register access. Subhash> To prevent possible unclock register access, this change adds Subhash> one more argument to setup_clocks callback to let it know Subhash> whether it is called pre/post the clock changes by core driver. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering