Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754583AbcJKWdm (ORCPT ); Tue, 11 Oct 2016 18:33:42 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:35829 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754298AbcJKWdk (ORCPT ); Tue, 11 Oct 2016 18:33:40 -0400 Subject: Re: [PATCH] arm64: defconfig: enable EEPROM_AT25 config option To: Arnd Bergmann , Florian Fainelli References: <1475875432-13627-1-git-send-email-scott.branden@broadcom.com> <1503155.onL8VV3RJv@wuerfel> Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, BCM Kernel Feedback From: Scott Branden Message-ID: Date: Tue, 11 Oct 2016 15:33:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1503155.onL8VV3RJv@wuerfel> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 765 Lines: 26 Hi Arnd, On 16-10-10 02:20 AM, Arnd Bergmann wrote: > On Monday, October 10, 2016 2:08:05 AM CEST Florian Fainelli wrote: >> On 10/07/2016 02:23 PM, Scott Branden wrote: >>> Enable support for on board SPI EEPROM by turning on >>> CONFIG_EEPROM_AT25. >>> >>> Signed-off-by: Scott Branden >> >> Looks fine to me, unless this needs to be a module, Arnd, what do you think? > > Please either make it a module or explain in the patch description > why it should be built-in. We use a fixed rootfs image to test the kernel. For simplicity we don't construct a rootfs or load any modules. We just test the kernel image. So for us every defconfig we use needs to be set to y to use the upstreamed kernel. > > Arnd > Regards, Scott