Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933472AbcJLCHY (ORCPT ); Tue, 11 Oct 2016 22:07:24 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:65492 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754283AbcJLCHP (ORCPT ); Tue, 11 Oct 2016 22:07:15 -0400 Subject: Re: [PATCH] ACPI: fix the process flow for 0 which return from acpi_register_gsi To: MaJun , , , , , References: <1476235256-10744-1-git-send-email-majun258@huawei.com> CC: From: Hanjun Guo Message-ID: <57FD9A81.5020701@huawei.com> Date: Wed, 12 Oct 2016 10:05:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1476235256-10744-1-git-send-email-majun258@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.17.188] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 797 Lines: 24 On 2016/10/12 9:20, MaJun wrote: > The return value 0 from acpi_register_gsi() means irq mapping failed. > So, we should process this case in else branch. > > Signed-off-by: MaJun > --- > drivers/acpi/resource.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c > index 56241eb..9918326 100644 > --- a/drivers/acpi/resource.c > +++ b/drivers/acpi/resource.c > @@ -416,7 +416,7 @@ static void acpi_dev_get_irqresource(struct resource *res, u32 gsi, > > res->flags = acpi_dev_irq_flags(triggering, polarity, shareable); > irq = acpi_register_gsi(NULL, gsi, triggering, polarity); > - if (irq >= 0) { > + if (irq > 0) { On x86 or IA64, irq 0 is a valid irq number as far as I know. Thanks Hanjun